AkkomaGang/akkoma
AkkomaGang/akkoma
16
67
Fork 105
Code Issues 167 Pull requests 14 Projects 2 Releases 19 Packages Wiki Activity

Use WebFinger domain for user's fqn #936

Closed
z411 wants to merge 2 commits from z411/akkoma:webfinger-fix into develop
pull from: z411/akkoma:webfinger-fix
merge into: AkkomaGang:develop
Conversation 2 Commits 2 Files changed 2 +15 -5
z411 commented 2025-05-27 23:28:31 +00:00
First-time contributor
Copy link

According to the original implementation the WebFinger domain is the correct domain for the user's fqn; it should've been merged along with #927. Also fixes #931.

According to the original implementation the WebFinger domain is the correct domain for the user's fqn; it should've been merged along with #927. Also fixes #931.
z411 added 2 commits 2025-05-27 23:28:32 +00:00
Update tests
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending approval
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending approval
Details
ci/woodpecker/pr/docs Pipeline is pending approval
Details
ci/woodpecker/pr/lint Pipeline is pending approval
Details
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/lint Pipeline was successful
Details
ci/woodpecker/pull_request_closed/test/1 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/test/2 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-arm64 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-amd64 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/docs Pipeline was successful
Details
fc8b98683e
Oneric commented 2025-05-28 16:01:25 +00:00
Owner
Copy link

#927 addressed a Mastodon compat issue, but fqn is an *oma extension and the original implementation is using the API domain as I’ve told you before in the closed issue.

This was added in 60b4654038 for use as a stable identifier for authentication on other services. Changing the identifier now will break all such existing account links for servers with a custom WebFinger domain.
Furthermore, the info can already be obtained via the standard MastoAPI fields accounts::nickname and instance::uri. Unless the client is really *oma-specific this reconstruction from the standard fields must already be supported anyway. Imho it makes no sense to break OAuth sessions for negligible simplicity gain in *oma-exclusive clients.

... although I see Pleroma changed the domain part anyway a while ago alongside a similar Masto-compat fix without discussing the effects on Oauth sessions anywhere: https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3958
This means the field is now inconsistent between *omas, but the OAuth breakages remain an issue, so I’d rather not change it still

#927 addressed a Mastodon compat issue, but `fqn` is an \*oma extension and the original implementation *is* using the API domain as I’ve told you before in the closed issue. This was added in 60b46540380e1467dcc0a93f7bfded84c5e98c64 for use as a stable identifier for authentication on other services. Changing the identifier now *will* break all such existing account links for servers with a custom WebFinger domain. Furthermore, the info can already be obtained via the standard MastoAPI fields `accounts::nickname` and `instance::uri`. Unless the client is really \*oma-specific this reconstruction from the standard fields must already be supported anyway. Imho it makes no sense to break OAuth sessions for negligible simplicity gain in \*oma-exclusive clients. ... although I see Pleroma changed the domain part anyway a while ago alongside a similar Masto-compat fix without discussing the effects on Oauth sessions anywhere: https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3958 This means the field is now inconsistent between \*omas, but the OAuth breakages remain an issue, so I’d rather not change it still
z411 commented 2025-05-28 20:47:25 +00:00
Author
First-time contributor
Copy link

I see, I'll look into fixing it client-side.

I see, I'll look into fixing it client-side.
z411 closed this pull request 2025-05-28 20:47:25 +00:00
Some checks are pending
ci/woodpecker/pr/build-amd64 Pipeline is pending approval
Details
ci/woodpecker/pr/build-arm64 Pipeline is pending approval
Details
ci/woodpecker/pr/docs Pipeline is pending approval
Details
ci/woodpecker/pr/lint Pipeline is pending approval
Details
ci/woodpecker/pr/test/1 Pipeline is pending approval
Details
ci/woodpecker/pr/test/2 Pipeline is pending approval
Details
ci/woodpecker/pull_request_closed/lint Pipeline was successful
Details
ci/woodpecker/pull_request_closed/test/1 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/test/2 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-arm64 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/build-amd64 Pipeline was successful
Details
ci/woodpecker/pull_request_closed/docs Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
approved, awaiting change

   
bug

Something is not working

  
configuration

This requires config changes

  
documentation

This is about human-readable docs

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
extremely low priority

   
feature request

Something new?

  
Fix it yourself

Support has been attempted

  
help wanted

Need some help

  
invalid

Something is wrong

  
mastodon_api

   
needs change/feedback

Issue or PR is stalled on response from the author or a third party

  
needs docs

   
needs tests

   
not a bug

   
planned

   
pleroma_api

   
privacy

   
question

More information is needed

  
static_fe

   
triage

   
wontfix

This won't be fixed

No labels
approved, awaiting change
bug
configuration
documentation
duplicate
enhancement
extremely low priority
feature request
Fix it yourself
help wanted
invalid
mastodon_api
needs change/feedback
needs docs
needs tests
not a bug
planned
pleroma_api
privacy
question
static_fe
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#936
No description provided.
Delete branch "z411/akkoma:webfinger-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?