Fix Finch timeout config options #939

Merged

Oneric merged 2 commits from Oneric/akkoma:finch-timeouts into develop 2025-06-08 11:11:13 +00:00

Conversation 0 Commits 2 Files changed 5 +7 -7

Oneric commented 2025-06-08 10:42:17 +00:00

Owner

Copy link

They’re duplicated and the one that’ſ actually used is lower than receive timeouts leading to (more frequent) issues from a race condition; see: https://github.com/sneako/finch/pull/292

I’ve changed the config for my option to the new default 60s a while ago without running into the race conditions again since

They’re duplicated and the one that’ſ actually used is lower than receive timeouts leading to (more frequent) issues from a race condition; see: https://github.com/sneako/finch/pull/292 I’ve changed the config for my option to the new default 60s a while ago without running into the race conditions again since

Oneric added 2 commits 2025-06-08 10:42:18 +00:00

config: drop unused duplicate finch pool timeout config ... 07abbd8de5

This was added in a924e117fd
with its name mirroring Finch’s own config option, but with
pool_timeout such a setting already existed since
2fe1484ed3 and the new one
was never actually used.

config: raise Finch pool timeout ... 80a65be38f

A pool timeout shorter than the receive timeout
makes race conditions leading to active connections
being killed more likely and laso just doesn’t make
much sense in general.

See: https://github.com/sneako/finch/pull/292

Oneric referenced this pull request 2025-06-08 10:42:57 +00:00

[bug] Active processes get terminated by nimble_pool idle shutdown #880

Oneric merged commit 242e798054 into develop 2025-06-08 11:11:13 +00:00

Oneric deleted branch finch-timeouts 2025-06-08 11:11:13 +00:00

Oneric referenced this pull request from a commit 2025-06-08 11:11:14 +00:00

Merge pull request 'Fix Finch timeout config options' (#939) from Oneric/akkoma:finch-timeouts into develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

approved, awaiting change

  

bug

Something is not working

  

configuration

This requires config changes

  

documentation

This is about human-readable docs

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

extremely low priority

  

feature request

Something new?

  

Fix it yourself

Support has been attempted

  

help wanted

Need some help

  

invalid

Something is wrong

  

mastodon_api

  

needs change/feedback

Issue or PR is stalled on response from the author or a third party

  

needs docs

  

needs tests

  

not a bug

  

planned

  

pleroma_api

  

privacy

  

question

More information is needed

  

static_fe

  

triage

  

wontfix

This won't be fixed

No labels

approved, awaiting change

bug

configuration

documentation

duplicate

enhancement

extremely low priority

feature request

Fix it yourself

help wanted

invalid

mastodon_api

needs change/feedback

needs docs

needs tests

not a bug

planned

pleroma_api

privacy

question

static_fe

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma#939

No description provided.