akkoma/test/support
Oneric 8684964c5d Only allow exact id matches
This protects us from falling for obvious spoofs as from the current
upload exploit (unfortunately we can’t reasonably do anything about
spoofs with exact matches as was possible via emoji and proxy).

Such objects being invalid is supported by the spec, sepcifically
sections 3.1 and 3.2: https://www.w3.org/TR/activitypub/#obj-id

Anonymous objects are not relevant here (they can only exists within
parent objects iiuc) and neither is client-to-server or transient objects
(as those cannot be fetched in the first place).
This leaves us with the requirement for `id` to (a) exist and
(b) be a publicly dereferencable URI from the originating server.
This alone does not yet demand strict equivalence, but the spec then
further explains objects ought to be fetchable _via their ID_.
Meaning an object not retrievable via its ID, is invalid.

This reading is supported by the fact, e.g. GoToSocial (recently) and
Mastodon (for 6+ years) do already implement such strict ID checks,
additionally proving this doesn’t cause federation issues in practice.

However, apart from canonical IDs there can also be additional display
URLs. *omas first redirect those to their canonical location, but *keys
and Mastodon directly serve the AP representation without redirects.

Mastodon and GTS deal with this in two different ways,
but both constitute an effective countermeasure:
 - Mastodon:
   Unless it already is a known AP id, two fetches occur.
   The first fetch just reads the `id` property and then refetches from
   the id. The last fetch requires the returned id to exactly match the
   URL the content was fetched from. (This can be optimised by skipping
   the second fetch if it already matches)
   05eda8d193/app/helpers/jsonld_helper.rb (L168)
   63f0979799

 - GTS:
   Only does a single fetch and then checks if _either_ the id
   _or_ url property (which can be an object) match the original fetch
   URL. This relies on implementations always including their display URL
   as "url" if differing from the id. For actors this is true for all
   investigated implementations, for posts only Mastodon includes an
   "url", but it is also the only one with a differing display URL.
   2bafd7daf5 (diff-943bbb02c8ac74ac5dc5d20807e561dcdfaebdc3b62b10730f643a20ac23c24fR222)

Albeit Mastodon’s refetch offers higher compatibility with theoretical
implmentations using either multiple different display URL or not
denoting any of them as "url" at all, for now we chose to adopt a
GTS-like refetch-free approach to avoid additional implementation
concerns wrt to whether redirects should be allowed when fetching a
canonical AP id and potential for accidentally loosening some checks
(e.g. cross-domain refetches) for one of the fetches.
This may be reconsidered in the future.
2024-03-25 14:05:05 -01:00
..
builders argon2 password hashing (#406) 2022-12-30 02:46:58 +00:00
captcha Bump Copyright to 2021 2021-01-13 07:49:50 +01:00
matchers Fix signature checking 2023-08-07 16:17:17 +01:00
api_spec_helpers.ex CI: Bump lint stage to elixir-1.12 2021-10-06 08:11:05 +02:00
cachex_proxy.ex Bump Copyright to 2021 2021-01-13 07:49:50 +01:00
channel_case.ex Mox mode setup tweak; refactoring. 2021-01-19 00:23:39 +03:00
cluster.ex giant massive dep upgrade and dialyxir-found error emporium (#371) 2022-12-14 12:38:48 +00:00
conn_case.ex Migrate to phoenix 1.7 (#626) 2023-08-15 10:22:18 +00:00
data_case.ex Migrate to phoenix 1.7 (#626) 2023-08-15 10:22:18 +00:00
elasticsearch_mock.ex Add elasticsearch tests 2022-06-30 16:53:21 +01:00
factory.ex Prune old Update activities 2024-02-17 16:57:40 +01:00
helpers.ex Support elixir1.15 2023-08-03 17:44:09 +01:00
http_request_mock.ex Only allow exact id matches 2024-03-25 14:05:05 -01:00
mocks.ex Bump Copyright to 2021 2021-01-13 07:49:50 +01:00
mrf_module_mock.ex MRF: create MRF.Policy behaviour separate from MRF module 2021-06-07 14:22:08 -05:00
null_cache.ex Bump Copyright to 2021 2021-01-13 07:49:50 +01:00
oban_helpers.ex Bump Copyright to 2021 2021-01-13 07:49:50 +01:00
websocket_client.ex Disconnect streaming sessions when token is revoked 2022-08-27 19:07:48 +01:00