1f863f0a36
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Objects who got updated would just pass through several of the MRF policies, undoing moderation in some situations.
In the relevant cases we now check not only for Create activities, but also Update activities.
I checked which ones checked explicitly on type Create using `grep '"type" => "Create"' lib/pleroma/web/activity_pub/mrf/*`.
The following from that list have not been changed:
* lib/pleroma/web/activity_pub/mrf/follow_bot_policy.ex
* Not relevant for moderation
* lib/pleroma/web/activity_pub/mrf/keyword_policy.ex
* Already had a test for Update
* lib/pleroma/web/activity_pub/mrf/object_age_policy.ex
* In practice only relevant when fetching old objects (e.g. through Like or Announce). These are always wrapped in a Create.
* lib/pleroma/web/activity_pub/mrf/reject_non_public.ex
* We don't allow changing scope with Update, so not relevant here
46 lines
1.3 KiB
Elixir
46 lines
1.3 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.ActivityPub.MRF.MentionPolicy do
|
|
@moduledoc "Block messages which mention a user"
|
|
|
|
@behaviour Pleroma.Web.ActivityPub.MRF.Policy
|
|
|
|
@impl true
|
|
def filter(%{"type" => type} = message) when type in ["Create", "Update"] do
|
|
reject_actors = Pleroma.Config.get([:mrf_mention, :actors], [])
|
|
recipients = (message["to"] || []) ++ (message["cc"] || [])
|
|
|
|
if rejected_mention =
|
|
Enum.find(recipients, fn recipient -> Enum.member?(reject_actors, recipient) end) do
|
|
{:reject, "[MentionPolicy] Rejected for mention of #{rejected_mention}"}
|
|
else
|
|
{:ok, message}
|
|
end
|
|
end
|
|
|
|
@impl true
|
|
def filter(message), do: {:ok, message}
|
|
|
|
@impl true
|
|
def describe, do: {:ok, %{}}
|
|
|
|
@impl true
|
|
def config_description do
|
|
%{
|
|
key: :mrf_mention,
|
|
related_policy: "Pleroma.Web.ActivityPub.MRF.MentionPolicy",
|
|
label: "MRF Mention",
|
|
description: "Block messages which mention a specific user",
|
|
children: [
|
|
%{
|
|
key: :actors,
|
|
type: {:list, :string},
|
|
description: "A list of actors for which any post mentioning them will be dropped",
|
|
suggestions: ["actor1", "actor2"]
|
|
}
|
|
]
|
|
}
|
|
end
|
|
end
|