Oneric
0ec62acb9d
This actually was already intended before to eradict all future path-traversal-style exploits and to fix issues with some characters like akkoma#610 in0b2ec0ccee. However, Dedupe and AnonymizeFilename got mixed up. The latter only anonymises the name in Content-Disposition headers GET parameters (with link_name), _not_ the upload path. Even without Dedupe, the upload path is prefixed by an UUID, so it _should_ already be hard to guess for attackers. But now we actually can be sure no path shenanigangs occur, uploads reliably work and save some disk space. While this makes the final path predictable, this prediction is not exploitable. Insertion of a back-reference to the upload itself requires pulling off a successfull preimage attack against SHA-256, which is deemed infeasible for the foreseeable futures. Dedupe was already included in the default list in config.exs since28cfb2c37a, but this will get overridde by whatever the config generated by the "pleroma.instance gen" task chose. Upload+delete tests running in parallel using Dedupe might be flaky, but this was already true before and needs its own commit to fix eventually.
60 lines
1.7 KiB
Elixir
60 lines
1.7 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Mix.Tasks.Pleroma.UploadsTest do
|
|
alias Pleroma.Upload
|
|
use Pleroma.DataCase, async: false
|
|
@moduletag :mocked
|
|
|
|
import Mock
|
|
|
|
setup_all do
|
|
Mix.shell(Mix.Shell.Process)
|
|
|
|
on_exit(fn ->
|
|
Mix.shell(Mix.Shell.IO)
|
|
end)
|
|
|
|
:ok
|
|
end
|
|
|
|
setup do: clear_config([Pleroma.Upload, :uploader], Pleroma.Uploaders.Local)
|
|
|
|
describe "running migrate_local" do
|
|
test "uploads migrated" do
|
|
File.copy!("test/fixtures/video.mp4", "test/uploads/video.mp4")
|
|
|
|
with_mock Upload,
|
|
store: fn %Upload{name: _file, path: _path}, _opts -> {:ok, %{}} end do
|
|
Mix.Tasks.Pleroma.Uploads.run(["migrate_local", "S3"])
|
|
|
|
assert_receive {:mix_shell, :info, [message]}, 1_000
|
|
assert message =~ "Migrating files from local"
|
|
|
|
assert_receive {:mix_shell, :info, [message]}, 1_000
|
|
|
|
assert %{"total_count" => total_count} =
|
|
Regex.named_captures(~r"^Found (?<total_count>\d+) uploads$", message)
|
|
|
|
assert_receive {:mix_shell, :info, [message]}, 1_000
|
|
|
|
count =
|
|
min(50, String.to_integer(total_count))
|
|
|> to_string()
|
|
|
|
assert %{"count" => ^count, "total_count" => ^total_count} =
|
|
Regex.named_captures(
|
|
~r"^Uploaded (?<count>\d+)/(?<total_count>\d+) files$",
|
|
message
|
|
)
|
|
end
|
|
end
|
|
|
|
test "nonexistent uploader" do
|
|
assert_raise RuntimeError, ~r/The uploader .* is not an existing/, fn ->
|
|
Mix.Tasks.Pleroma.Uploads.run(["migrate_local", "nonexistent"])
|
|
end
|
|
end
|
|
end
|
|
end
|