Oneric
932810c35e
Some checks are pending
ci/woodpecker/pull_request_closed/build-amd64 Pipeline is pending approval
ci/woodpecker/pull_request_closed/build-arm64 Pipeline is pending approval
ci/woodpecker/pull_request_closed/docs Pipeline is pending approval
ci/woodpecker/pull_request_closed/test Pipeline is pending approval
ci/woodpecker/pull_request_closed/lint Pipeline is pending approval
ci/woodpecker/pr/build-amd64 Pipeline is pending approval
ci/woodpecker/pr/build-arm64 Pipeline is pending approval
ci/woodpecker/pr/docs Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
ci/woodpecker/pr/test Pipeline is pending approval
Current logic unconditionally adds public adressing to "cc"
and follower adressing to "to" after attempting to strip it
from the other one. This creates serious problems:
First the bug prompting this investigation and fix,
unconditional addition creates duplicates when adressing
URIs already were in their intended final field; e.g.
this is prominently the case for all "unlisted" posts.
Since List.delete only removes the first occurence,
this then broke follower-adress stripping later on
making the policy ineffective.
It’s also just not safe in general wrt to non-public adressing:
e.g. pre-existing duplicates didn’t get fully stripped,
bespoke adressing modes with only one of public addressing
or follower addressing are mangled — and most importantly:
any belatedly received DM or follower-only post
also got public adressing added!
Shockingly this last point was actually asserted as "correct" in tests;
it appears to be a mistake from mindless match adjustments
while fixing crashes on nil adressing in
|
||
|---|---|---|
| .. | ||
| activity | ||
| akkoma | ||
| collections | ||
| config | ||
| conversation | ||
| docs | ||
| ecto_type/activity_pub/object_validators | ||
| emails | ||
| emoji | ||
| http | ||
| instances | ||
| integration | ||
| mfa | ||
| migration_helper | ||
| object | ||
| password | ||
| repo/migrations | ||
| search | ||
| translators | ||
| upload | ||
| uploaders | ||
| user | ||
| web | ||
| workers | ||
| activity_test.exs | ||
| announcement_read_relationship_test.exs | ||
| announcement_test.exs | ||
| application_requirements_test.exs | ||
| bookmark_test.exs | ||
| captcha_test.exs | ||
| config_db_test.exs | ||
| config_test.exs | ||
| conversation_test.exs | ||
| emoji_test.exs | ||
| filter_test.exs | ||
| following_relationship_test.exs | ||
| formatter_test.exs | ||
| frontend_test.exs | ||
| hashtag_test.exs | ||
| healthcheck_test.exs | ||
| html_test.exs | ||
| http_test.exs | ||
| instances_test.exs | ||
| iso639_test.exs | ||
| job_queue_monitor_test.exs | ||
| list_test.exs | ||
| marker_test.exs | ||
| mfa_test.exs | ||
| moderation_log_test.exs | ||
| notification_test.exs | ||
| object_test.exs | ||
| otp_version_test.exs | ||
| pagination_test.exs | ||
| password_test.exs | ||
| registration_test.exs | ||
| repo_test.exs | ||
| report_note_test.exs | ||
| reverse_proxy_test.exs | ||
| runtime_test.exs | ||
| safe_jsonb_set_test.exs | ||
| scheduled_activity_test.exs | ||
| signature_test.exs | ||
| stats_test.exs | ||
| upload_test.exs | ||
| user_invite_token_test.exs | ||
| user_note_test.exs | ||
| user_relationship_test.exs | ||
| user_search_test.exs | ||
| user_test.exs | ||
| utils_test.exs | ||
| xml_builder_test.exs | ||