ca56527140
* Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each
77 lines
2.2 KiB
Ruby
77 lines
2.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class ActivityPub::DeliveryWorker
|
|
include Sidekiq::Worker
|
|
include RoutingHelper
|
|
include JsonLdHelper
|
|
|
|
STOPLIGHT_FAILURE_THRESHOLD = 10
|
|
STOPLIGHT_COOLDOWN = 60
|
|
|
|
sidekiq_options queue: 'push', retry: 16, dead: false
|
|
|
|
HEADERS = { 'Content-Type' => 'application/activity+json' }.freeze
|
|
|
|
def perform(json, source_account_id, inbox_url, options = {})
|
|
return unless DeliveryFailureTracker.available?(inbox_url)
|
|
|
|
@options = options.with_indifferent_access
|
|
@json = json
|
|
@source_account = Account.find(source_account_id)
|
|
@inbox_url = inbox_url
|
|
@host = Addressable::URI.parse(inbox_url).normalized_site
|
|
@performed = false
|
|
|
|
perform_request
|
|
ensure
|
|
if @inbox_url.present?
|
|
if @performed
|
|
failure_tracker.track_success!
|
|
else
|
|
failure_tracker.track_failure!
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def build_request(http_client)
|
|
Request.new(:post, @inbox_url, body: @json, http_client: http_client).tap do |request|
|
|
request.on_behalf_of(@source_account, :uri, sign_with: @options[:sign_with])
|
|
request.add_headers(HEADERS)
|
|
request.add_headers({ 'Collection-Synchronization' => synchronization_header }) if ENV['DISABLE_FOLLOWERS_SYNCHRONIZATION'] != 'true' && @options[:synchronize_followers]
|
|
end
|
|
end
|
|
|
|
def synchronization_header
|
|
"collectionId=\"#{account_followers_url(@source_account)}\", digest=\"#{@source_account.remote_followers_hash(inbox_url_prefix)}\", url=\"#{account_followers_synchronization_url(@source_account)}\""
|
|
end
|
|
|
|
def inbox_url_prefix
|
|
@inbox_url[/http(s?):\/\/[^\/]+\//]
|
|
end
|
|
|
|
def perform_request
|
|
light = Stoplight(@inbox_url) do
|
|
request_pool.with(@host) do |http_client|
|
|
build_request(http_client).perform do |response|
|
|
raise Mastodon::UnexpectedResponseError, response unless response_successful?(response) || response_error_unsalvageable?(response)
|
|
|
|
@performed = true
|
|
end
|
|
end
|
|
end
|
|
|
|
light.with_threshold(STOPLIGHT_FAILURE_THRESHOLD)
|
|
.with_cool_off_time(STOPLIGHT_COOLDOWN)
|
|
.run
|
|
end
|
|
|
|
def failure_tracker
|
|
@failure_tracker ||= DeliveryFailureTracker.new(@inbox_url)
|
|
end
|
|
|
|
def request_pool
|
|
RequestPool.current
|
|
end
|
|
end
|