* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
59 lines
1.4 KiB
Ruby
59 lines
1.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Api::V1::Lists::AccountsController do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
|
|
let(:list) { Fabricate(:list, account: user.account) }
|
|
|
|
before do
|
|
follow = Fabricate(:follow, account: user.account)
|
|
list.accounts << follow.target_account
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
let(:scopes) { 'read:lists' }
|
|
|
|
it 'returns http success' do
|
|
get :show, params: { list_id: list.id }
|
|
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
let(:scopes) { 'write:lists' }
|
|
let(:bob) { Fabricate(:account, username: 'bob') }
|
|
|
|
before do
|
|
user.account.follow!(bob)
|
|
post :create, params: { list_id: list.id, account_ids: [bob.id] }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'adds account to the list' do
|
|
expect(list.accounts.include?(bob)).to be true
|
|
end
|
|
end
|
|
|
|
describe 'DELETE #destroy' do
|
|
let(:scopes) { 'write:lists' }
|
|
|
|
before do
|
|
delete :destroy, params: { list_id: list.id, account_ids: [list.accounts.first.id] }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'removes account from the list' do
|
|
expect(list.accounts.count).to eq 0
|
|
end
|
|
end
|
|
end
|