Fix the jelly animation #1

New Issue

Open

opened 2023-03-01 10:43:11 +00:00 by lewdum · 4 comments

lewdum commented

2023-03-01 10:43:11 +00:00

Hi!

I've noticed that the $[jelly XYZ] syntax does not work. It seems that, when the parser was "ported" from Misskey, the CSS class was renamed to _mfm_jelly_ but the animation name was kept mfm-rubberBand. However, akkoma-fe defines this animation by the name mfm-jelly instead. Technically, either one could be changed, but I think it would be more consistent to do it here.

This is the exact line that needs to be changed: 912fba8115/lib/encoder.ex (L97)

Thanks.

Hi! I've noticed that the `$[jelly XYZ]` syntax does not work. It seems that, when the parser was "ported" from Misskey, the CSS class was renamed to `_mfm_jelly_` but the animation name was kept `mfm-rubberBand`. However, `akkoma-fe` defines this animation by the name `mfm-jelly` instead. Technically, either one could be changed, but I think it would be more consistent to do it here. This is the exact line that needs to be changed: https://akkoma.dev/AkkomaGang/mfm-parser/src/commit/912fba81152d4d572e457fd5427f9875b2bc3dbe/lib/encoder.ex#L97 Thanks.

floatingghost commented

2023-03-10 04:00:08 +00:00

Owner

this shouldn't really matter too much now since we strip all css on the backend now

so i think the most consistent thing would be to remove the generation of styles here - i've tested and it currently works on develop akkoma-fe

this shouldn't really matter too much now since we strip all css on the backend now so i think the most consistent thing would be to remove the generation of styles here - i've tested and it currently works on develop akkoma-fe

lewdum commented

2023-03-12 14:00:52 +00:00

Author

Thanks for the reply! I am a bit confused though, are you saying that these effects will be handled elsewhere or that they will be completely removed moving forward?