AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 82 Pull requests 20 Projects Releases 1 Wiki Activity

Decode html-encoded characters inside pre tags #101

Merged
floatingghost merged 1 commit from :mfm-htmlencode into develop 2022-08-04 07:52:59 +00:00
Conversation 1 Commits 1 Files changed 1 +9 -2
Ghost commented 2022-08-02 09:41:30 +00:00
First-time contributor
Copy link

listen. i know. how bad this looks
but

  • since we're handling markdown in the frontend after html is already handled in the backend there's really no other way to do it
  • this is safe, because it only applies to pre tags, you can't inject anything into this

it's so ugly though

listen. i know. how bad this looks but - since we're handling markdown in the frontend after html is already handled in the backend there's really no other way to do it - this is safe, because it only applies to pre tags, you can't inject anything into this it's so ugly though
Ghost added 1 commit 2022-08-02 09:41:31 +00:00
Decode html-encoded characters inside pre tags
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
6441ff45a9
eris added the
Minor change
 label 2022-08-02 21:42:59 +00:00
floatingghost commented 2022-08-04 07:52:55 +00:00
Owner
Copy link

yeah pres should be safe but heck be careful with that sort of thing

yeah `pre`s should be safe but heck be careful with that sort of thing
floatingghost merged commit 9421aa1d39 into develop 2022-08-04 07:52:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#101
No description provided.
Delete branch ":mfm-htmlencode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?