AkkomaGang
/
akkoma-fe
4
13
Fork 56
Code Issues 72 Pull Requests 16 Projects Releases 1 Wiki Activity

Hide mentions of bubble timeline if empty #167

Merged
floatingghost merged 1 commits from nbsp/pleroma-fe:hide-bubble into develop 2022-09-20 14:16:02 +00:00
Conversation 5 Commits 1 Files Changed 5 +7 -4
nbsp commented 2022-09-14 18:45:40 +00:00
Contributor
Copy Link

also get rid of that ugly padding error that's been bugging me

also get rid of that ugly padding error that's been bugging me
nbsp added 1 commit 2022-09-14 18:45:40 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
b936506f47
Hide mentions of bubble timeline if empty
floatingghost commented 2022-09-14 21:08:11 +00:00
Owner
Copy Link

imo keep the option in the nav, since we'll always have at least 1 instance in the bubble timeline (us), but yes the panel changes look good

imo keep the option in the nav, since we'll always have at least 1 instance in the bubble timeline (us), but yes the panel changes look good
nbsp commented 2022-09-15 04:14:19 +00:00
Author
Contributor
Copy Link

well but in that case the bubble timeline is just the local timeline
i don't think it should be visible if it doesn't have a use

well but in that case the bubble timeline is just the local timeline i don't think it should be visible if it doesn't have a use
floatingghost commented 2022-09-15 10:50:43 +00:00
Owner
Copy Link

i'm just sorta worrying that the second we do this we'll get an issue like "where is the bubble timeline it's not there"

it might be identical to the local timeline, but it's still a valid timeline

i'm just sorta worrying that the second we do this we'll get an issue like "where is the bubble timeline it's not there" it might be identical to the local timeline, but it's still a valid timeline
nbsp commented 2022-09-15 17:40:55 +00:00
Author
Contributor
Copy Link

i think it's about as likely that, if the panel is removed, you'll get questions about "what's the bubble timeline" because it appears without listing anything

i think it's about as likely that, if the panel is removed, you'll get questions about "what's the bubble timeline" because it appears without listing anything
floatingghost commented 2022-09-20 14:15:56 +00:00
Owner
Copy Link

fair enough

i'll append onto it with a doc entry explaining the rationale

fair enough i'll append onto it with a doc entry explaining the rationale
floatingghost merged commit 38d50acaeb into develop 2022-09-20 14:16:02 +00:00
floatingghost deleted branch hide-bubble 2022-09-20 14:16:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No Label
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#167
No description provided.
Delete Branch "nbsp/pleroma-fe:hide-bubble"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?