Hide mentions of bubble timeline if empty #167

Merged

floatingghost merged 1 commit from :hide-bubble into develop

2022-09-20 14:16:02 +00:00

Ghost commented

2022-09-14 18:45:40 +00:00

First-time contributor

also get rid of that ugly padding error that's been bugging me

Ghost added 1 commit 2022-09-14 18:45:40 +00:00

Hide mentions of bubble timeline if empty

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

b936506f47

floatingghost commented

2022-09-14 21:08:11 +00:00

Owner

imo keep the option in the nav, since we'll always have at least 1 instance in the bubble timeline (us), but yes the panel changes look good

Ghost commented

2022-09-15 04:14:19 +00:00

Author

First-time contributor

well but in that case the bubble timeline is just the local timeline
i don't think it should be visible if it doesn't have a use

well but in that case the bubble timeline is just the local timeline i don't think it should be visible if it doesn't have a use

floatingghost commented

2022-09-15 10:50:43 +00:00

Owner

i'm just sorta worrying that the second we do this we'll get an issue like "where is the bubble timeline it's not there"

it might be identical to the local timeline, but it's still a valid timeline

i'm just sorta worrying that the second we do this we'll get an issue like "where is the bubble timeline it's not there" it might be identical to the local timeline, but it's still a valid timeline

Ghost commented

2022-09-15 17:40:55 +00:00

Author

First-time contributor

i think it's about as likely that, if the panel is removed, you'll get questions about "what's the bubble timeline" because it appears without listing anything