AkkomaGang/akkoma-fe
5
13
Fork 64
Code Issues 81 Pull requests 19 Projects Releases 1 Wiki Activity

Use Marked and marked-mfm for MFM rendering #29

Merged
floatingghost merged 7 commits from :marked-mfm into develop 2022-07-15 09:57:17 +00:00
Conversation 8 Commits 7 Files changed 9 +3812 -2817
Ghost commented 2022-07-09 11:40:36 +00:00
First-time contributor
Copy link

significantly simplifies completely removes mfm_content.jsx, instead relying on RichContent. moves styling to mfm.css.

  • mfm attributes with values (.speed=3s, .deg=20) don't work, since the css attr() function doesn't work on animation or transform. need to mutate the output HTML manually.
  • mentions and hashtags don't work (akkomagang/akkoma#58)
  • general ugliness that i need to fix before it's ready
~~significantly simplifies~~ *completely removes* `mfm_content.jsx`, instead relying on `RichContent`. moves styling to `mfm.css`. - [x] mfm attributes with values (`.speed=3s`, `.deg=20`) don't work, since the css `attr()` function doesn't work on `animation` or `transform`. need to mutate the output HTML manually. - [x] mentions and hashtags don't work (akkomagang/akkoma#58) - [x] general ugliness that i need to fix before it's ready
Ghost added 2 commits 2022-07-09 11:40:37 +00:00
Use Marked and marked-mfm for MFM rendering
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
83a3b37f1f
Ghost commented 2022-07-10 07:41:54 +00:00
Author
First-time contributor
Copy link

this last commit doesn't work on current akkoma, as it relies on the proposed changes to the backend, where status.content_type is a thing and the MFM content is in raw_html wait no i'm dumb actually i should be able to do more than this

~~this last commit doesn't work on current akkoma, as it relies on the proposed changes to the backend, where `status.content_type` is a thing and the MFM content is in `raw_html`~~ wait no i'm dumb actually i should be able to do more than this
Ghost force-pushed marked-mfm from 465db46dac to 52b19abaa3 2022-07-10 19:54:30 +00:00 Compare
Ghost force-pushed marked-mfm from 52b19abaa3 to faeadbb778 2022-07-10 19:57:17 +00:00 Compare
Ghost commented 2022-07-10 19:59:04 +00:00
Author
First-time contributor
Copy link

apart from search being completely and utterly broken, this works well!
i'll try to fix the search tomorrow

apart from search being completely and utterly broken, this works well! i'll try to fix the search tomorrow
Ghost force-pushed marked-mfm from faeadbb778 to 8861835580 2022-07-12 17:40:34 +00:00 Compare
Ghost commented 2022-07-12 17:44:40 +00:00
Author
First-time contributor
Copy link

with search yeeted, this pr is ready to merge

with search yeeted, this pr is ready to merge
Ghost changed title from [WIP] Use Marked and marked-mfm for MFM rendering to Use Marked and marked-mfm for MFM rendering 2022-07-12 17:44:42 +00:00
floatingghost commented 2022-07-12 19:28:45 +00:00
Owner
Copy link

:hanaPog: i'll try this tomorrow and make sure it all works gud(tm)

it'll be nice to purge that hacky mfm renderer

:hanaPog: i'll try this tomorrow and make sure it all works gud(tm) it'll be nice to purge that hacky mfm renderer
Ghost added 1 commit 2022-07-13 18:01:00 +00:00
Don't greentext MFM
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
a8f9734400
Ghost commented 2022-07-13 18:01:51 +00:00
Author
First-time contributor
Copy link

quick update: disabled meme arrows for MFM since they should be actual quotes anyway
and it messes with HTML tags

quick update: disabled meme arrows for MFM since they should be actual quotes anyway and it messes with HTML tags
floatingghost commented 2022-07-15 09:47:49 +00:00
Owner
Copy link

getting errors running the pr

Uncaught (in promise) TypeError: proxy set handler returned false for property '"greentext"'
render rich_content.jsx:75

seeing if there's an easy fix

getting errors running the pr >Uncaught (in promise) TypeError: proxy set handler returned false for property '"greentext"' > render rich_content.jsx:75 seeing if there's an easy fix
floatingghost commented 2022-07-15 09:50:30 +00:00
Owner
Copy link

ah right the quick fix applied on this pr changes props which vue does not like, i'll shuffle the scope around

ah right the quick fix applied on this pr changes props which vue does not like, i'll shuffle the scope around
floatingghost commented 2022-07-15 09:57:09 +00:00
Owner
Copy link

but otherwise it all works, nice

i'll patch the two bugs i found, but the rest looks good

but otherwise it all works, nice i'll patch the two bugs i found, but the rest looks good
floatingghost merged commit 931ed3d3c7 into develop 2022-07-15 09:57:17 +00:00
Ghost deleted branch marked-mfm 2022-07-15 10:14:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
a11y

Issues and PRs about accessibility

  
Bug

Applies to issues describing bugs

  
Bug fix

Pull requests that squash bugs

  
Critical Priority

   
Documentation

  
Feature

Pull requests that implement new features

  
Feature request

Issues that request new features

  
Held for next release cycle

PR reviewed during release candidate phase, approved and held as PR

  
High Priority

   
Low Priority

   
Medium Priority

   
Minor change

For minor changes, ie CSS alignment changes

  
Translation/Locale

For changes related to translations

  
WIP

Work in progress

No labels
a11y
Bug
Bug fix
Critical Priority
Documentation
Feature
Feature request
Held for next release cycle
High Priority
Low Priority
Medium Priority
Minor change
Translation/Locale
WIP
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: AkkomaGang/akkoma-fe#29
No description provided.
Delete branch ":marked-mfm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?