Mark replies to muted users for muting #90

Merged
floatingghost merged 2 commits from eris/pleroma-fe:hide-replies-muted into develop 2022-08-01 11:12:02 +00:00
Contributor

One of my users requested this.

Marks a reply to a muted user for filtering. Doesn't need additional options in my opinion since the "hide muted threads" will take care of that.

Maybe eventually it'd be good to merge both functions into one if that's possible?

One of my users requested this. Marks a reply to a muted user for filtering. Doesn't need additional options in my opinion since the "hide muted threads" will take care of that. Maybe eventually it'd be good to merge both functions into one if that's possible?
eris added 1 commit 2022-08-01 02:55:40 +00:00
Hide replies to muted users
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
d49884a76f
Ghost requested changes 2022-08-01 05:47:16 +00:00
Ghost left a comment
First-time contributor

lgtm, just need to add this so it filters on "hide muted threads" when the select all is disabled

    hideStatus () {
      return (!this.shouldNotMute) && (
        (this.muted && this.hideFilteredStatuses) ||
        (this.userIsMuted && this.hideMutedUsers) ||
-       (this.status.thread_muted && this.hideMutedThreads) ||
+       ((this.status.thread_muted || this.mentionsMutedUser) && this.hideMutedThreads) ||
        (this.muteWordHits.length > 0 && this.hideWordFilteredPosts) ||
        (this.mentionsBlockedUser && this.hideThreadsWithBlockedUsers)
      )
    },
lgtm, just need to add this so it filters on "hide muted threads" when the select all is disabled ```suggestion hideStatus () { return (!this.shouldNotMute) && ( (this.muted && this.hideFilteredStatuses) || (this.userIsMuted && this.hideMutedUsers) || - (this.status.thread_muted && this.hideMutedThreads) || + ((this.status.thread_muted || this.mentionsMutedUser) && this.hideMutedThreads) || (this.muteWordHits.length > 0 && this.hideWordFilteredPosts) || (this.mentionsBlockedUser && this.hideThreadsWithBlockedUsers) ) }, ```
eris added 1 commit 2022-08-01 05:57:57 +00:00
Hide muted replies if muted threads enabled
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
f951bc436e
eris requested review from Ghost Team 2022-08-01 05:58:22 +00:00
Author
Contributor

Thanks, that works nicely. For some reason I thought it being marked muted would be enough

Thanks, that works nicely. For some reason I thought it being marked muted would be enough
Ghost approved these changes 2022-08-01 05:59:42 +00:00

using your code review powers i see
strong

using your code review powers i see strong
floatingghost merged commit 5f09326879 into develop 2022-08-01 11:12:02 +00:00
eris deleted branch hide-replies-muted 2022-08-07 08:05:11 +00:00
Sign in to join this conversation.
No description provided.