From 1d32d6ecc0ac0f572000451eb44f4963ad980fc3 Mon Sep 17 00:00:00 2001 From: Marcel Otto Date: Sun, 19 Jun 2022 21:30:00 +0200 Subject: [PATCH] Run tests without Coveralls as it doesn't support the --warnings-as-errors option --- .github/workflows/ci.yml | 4 +++- test/unit/graph_builder_test.exs | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bb5dc6b..06af5e2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,9 @@ jobs: - run: mix compile --warnings-as-errors if: ${{ matrix.lint }} - - run: MIX_ENV=test mix coveralls.github --warnings-as-errors +# TODO: ExCoveralls doesn't seem to support --warnings-as-errors which we rely on. +# - run: MIX_ENV=test mix coveralls.github --warnings-as-errors + - run: mix test --warnings-as-errors - name: Retrieve PLT Cache uses: actions/cache@v1 diff --git a/test/unit/graph_builder_test.exs b/test/unit/graph_builder_test.exs index 0d0193a..ab77d79 100644 --- a/test/unit/graph_builder_test.exs +++ b/test/unit/graph_builder_test.exs @@ -1,3 +1,5 @@ +# These tests rely on running with mix test --warnings-as-errors to ensure +# the undefined-function warnings raised at compile-time are caught properly. defmodule RDF.Graph.BuilderTest do use ExUnit.Case