Extract if block into private function

This commit is contained in:
kPherox 2019-08-26 17:09:32 +09:00 committed by Ariadne Conill
parent cc84563796
commit c5338764df

View file

@ -119,6 +119,14 @@ defp add_if_present(
end end
end end
defp normalize_fields_attributes(fields) do
if Enum.all?(fields, &is_tuple/1) do
Enum.map(fields, fn {_, v} -> v end)
else
fields
end
end
def update_credentials(%{assigns: %{user: user}} = conn, params) do def update_credentials(%{assigns: %{user: user}} = conn, params) do
original_user = user original_user = user
@ -146,11 +154,8 @@ def update_credentials(%{assigns: %{user: user}} = conn, params) do
params = params =
if Map.has_key?(params, "fields_attributes") do if Map.has_key?(params, "fields_attributes") do
Map.update!(params, "fields_attributes", fn fields -> Map.update!(params, "fields_attributes", fn fields ->
if Enum.all?(fields, &is_tuple/1) do
Enum.map(fields, fn {_, v} -> v end)
else
fields fields
end |> normalize_fields_attributes()
|> Enum.filter(fn %{"name" => n} -> n != "" end) |> Enum.filter(fn %{"name" => n} -> n != "" end)
end) end)
else else