tests: refactor ffVisibility tests
Using some closures to partly generate the tests to achieve better coverage
This commit is contained in:
parent
352851f23f
commit
3d4df807b0
GPG key ID:
9EE6577A2A06F8F1
1 changed files with 80 additions and 131 deletions
|
|
@ -9,159 +9,108 @@ describe('FF visibility', () => {
|
||||||
|
|
||||||
let alice: any;
|
let alice: any;
|
||||||
let bob: any;
|
let bob: any;
|
||||||
let carol: any;
|
let follower: any;
|
||||||
|
|
||||||
before(async () => {
|
before(async () => {
|
||||||
p = await startServer();
|
p = await startServer();
|
||||||
alice = await signup({ username: 'alice' });
|
alice = await signup({ username: 'alice' });
|
||||||
bob = await signup({ username: 'bob' });
|
bob = await signup({ username: 'bob' });
|
||||||
carol = await signup({ username: 'carol' });
|
follower = await signup({ username: 'follower' });
|
||||||
|
|
||||||
|
await request('/following/create', { userId: alice.id }, follower);
|
||||||
});
|
});
|
||||||
|
|
||||||
after(async () => {
|
after(async () => {
|
||||||
await shutdownServer(p);
|
await shutdownServer(p);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('ffVisibility が public なユーザーのフォロー/フォロワーを誰でも見れる', async(async () => {
|
const visible = (user) => {
|
||||||
await request('/i/update', {
|
return async () => {
|
||||||
ffVisibility: 'public',
|
const followingRes = await request('/users/following', {
|
||||||
}, alice);
|
userId: alice.id,
|
||||||
|
}, user);
|
||||||
|
const followersRes = await request('/users/followers', {
|
||||||
|
userId: alice.id,
|
||||||
|
}, user);
|
||||||
|
|
||||||
const followingRes = await request('/users/following', {
|
assert.strictEqual(followingRes.status, 200);
|
||||||
userId: alice.id,
|
assert.ok(Array.isArray(followingRes.body));
|
||||||
}, bob);
|
assert.strictEqual(followersRes.status, 200);
|
||||||
const followersRes = await request('/users/followers', {
|
assert.ok(Array.isArray(followersRes.body));
|
||||||
userId: alice.id,
|
};
|
||||||
}, bob);
|
};
|
||||||
|
|
||||||
assert.strictEqual(followingRes.status, 200);
|
const hidden = (user) => {
|
||||||
assert.strictEqual(Array.isArray(followingRes.body), true);
|
return async () => {
|
||||||
assert.strictEqual(followersRes.status, 200);
|
const followingRes = await request('/users/following', {
|
||||||
assert.strictEqual(Array.isArray(followersRes.body), true);
|
userId: alice.id,
|
||||||
}));
|
}, user);
|
||||||
|
const followersRes = await request('/users/followers', {
|
||||||
|
userId: alice.id,
|
||||||
|
}, user);
|
||||||
|
|
||||||
it('ffVisibility が followers なユーザーのフォロー/フォロワーを自分で見れる', async(async () => {
|
assert.strictEqual(followingRes.status, 403);
|
||||||
await request('/i/update', {
|
assert.strictEqual(followersRes.status, 403);
|
||||||
ffVisibility: 'followers',
|
};
|
||||||
}, alice);
|
};
|
||||||
|
|
||||||
const followingRes = await request('/users/following', {
|
describe('public visibility', () => {
|
||||||
userId: alice.id,
|
before(async () => {
|
||||||
}, alice);
|
await request('/i/update', {
|
||||||
const followersRes = await request('/users/followers', {
|
ffVisibility: 'public',
|
||||||
userId: alice.id,
|
}, alice);
|
||||||
}, alice);
|
});
|
||||||
|
|
||||||
assert.strictEqual(followingRes.status, 200);
|
it('shows followers and following to self', visible(alice));
|
||||||
assert.strictEqual(Array.isArray(followingRes.body), true);
|
it('shows followers and following to a follower', visible(follower));
|
||||||
assert.strictEqual(followersRes.status, 200);
|
it('shows followers and following to a non-follower', visible(bob));
|
||||||
assert.strictEqual(Array.isArray(followersRes.body), true);
|
it('shows followers and following when unauthenticated', visible(null));
|
||||||
}));
|
|
||||||
|
|
||||||
it('ffVisibility が followers なユーザーのフォロー/フォロワーを非フォロワーが見れない', async(async () => {
|
it('provides followers in ActivityPub representation', async () => {
|
||||||
await request('/i/update', {
|
const followingRes = await simpleGet(`/users/${alice.id}/following`, 'application/activity+json');
|
||||||
ffVisibility: 'followers',
|
const followersRes = await simpleGet(`/users/${alice.id}/followers`, 'application/activity+json');
|
||||||
}, alice);
|
assert.strictEqual(followingRes.status, 200);
|
||||||
|
assert.strictEqual(followersRes.status, 200);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
const followingRes = await request('/users/following', {
|
describe('followers visibility', () => {
|
||||||
userId: alice.id,
|
before(async () => {
|
||||||
}, bob);
|
await request('/i/update', {
|
||||||
const followersRes = await request('/users/followers', {
|
ffVisibility: 'followers',
|
||||||
userId: alice.id,
|
}, alice);
|
||||||
}, bob);
|
});
|
||||||
|
|
||||||
assert.strictEqual(followingRes.status, 400);
|
it('shows followers and following to self', visible(alice));
|
||||||
assert.strictEqual(followersRes.status, 400);
|
it('shows followers and following to a follower', visible(follower));
|
||||||
}));
|
it('hides followers and following from a non-follower', hidden(bob));
|
||||||
|
it('hides followers and following when unauthenticated', hidden(null));
|
||||||
|
|
||||||
it('ffVisibility が followers なユーザーのフォロー/フォロワーをフォロワーが見れる', async(async () => {
|
it('hides followers from ActivityPub representation', async () => {
|
||||||
await request('/i/update', {
|
const followingRes = await simpleGet(`/users/${alice.id}/following`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
||||||
ffVisibility: 'followers',
|
const followersRes = await simpleGet(`/users/${alice.id}/followers`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
||||||
}, alice);
|
assert.strictEqual(followingRes.status, 403);
|
||||||
|
assert.strictEqual(followersRes.status, 403);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
await request('/following/create', {
|
describe('private visibility', () => {
|
||||||
userId: alice.id,
|
before(async () => {
|
||||||
}, bob);
|
await request('/i/update', {
|
||||||
|
ffVisibility: 'private',
|
||||||
|
}, alice);
|
||||||
|
});
|
||||||
|
|
||||||
const followingRes = await request('/users/following', {
|
it('shows followers and following to self', visible(alice));
|
||||||
userId: alice.id,
|
it('hides followers and following from a follower', hidden(follower));
|
||||||
}, bob);
|
it('hides followers and following from a non-follower', hidden(bob));
|
||||||
const followersRes = await request('/users/followers', {
|
it('hides followers and following when unauthenticated', hidden(null));
|
||||||
userId: alice.id,
|
|
||||||
}, bob);
|
|
||||||
|
|
||||||
assert.strictEqual(followingRes.status, 200);
|
it('hides followers from ActivityPub representation', async () => {
|
||||||
assert.strictEqual(Array.isArray(followingRes.body), true);
|
const followingRes = await simpleGet(`/users/${alice.id}/following`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
||||||
assert.strictEqual(followersRes.status, 200);
|
const followersRes = await simpleGet(`/users/${alice.id}/followers`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
||||||
assert.strictEqual(Array.isArray(followersRes.body), true);
|
assert.strictEqual(followingRes.status, 403);
|
||||||
}));
|
assert.strictEqual(followersRes.status, 403);
|
||||||
|
});
|
||||||
it('ffVisibility が private なユーザーのフォロー/フォロワーを自分で見れる', async(async () => {
|
|
||||||
await request('/i/update', {
|
|
||||||
ffVisibility: 'private',
|
|
||||||
}, alice);
|
|
||||||
|
|
||||||
const followingRes = await request('/users/following', {
|
|
||||||
userId: alice.id,
|
|
||||||
}, alice);
|
|
||||||
const followersRes = await request('/users/followers', {
|
|
||||||
userId: alice.id,
|
|
||||||
}, alice);
|
|
||||||
|
|
||||||
assert.strictEqual(followingRes.status, 200);
|
|
||||||
assert.strictEqual(Array.isArray(followingRes.body), true);
|
|
||||||
assert.strictEqual(followersRes.status, 200);
|
|
||||||
assert.strictEqual(Array.isArray(followersRes.body), true);
|
|
||||||
}));
|
|
||||||
|
|
||||||
it('ffVisibility が private なユーザーのフォロー/フォロワーを他人が見れない', async(async () => {
|
|
||||||
await request('/i/update', {
|
|
||||||
ffVisibility: 'private',
|
|
||||||
}, alice);
|
|
||||||
|
|
||||||
const followingRes = await request('/users/following', {
|
|
||||||
userId: alice.id,
|
|
||||||
}, bob);
|
|
||||||
const followersRes = await request('/users/followers', {
|
|
||||||
userId: alice.id,
|
|
||||||
}, bob);
|
|
||||||
|
|
||||||
assert.strictEqual(followingRes.status, 400);
|
|
||||||
assert.strictEqual(followersRes.status, 400);
|
|
||||||
}));
|
|
||||||
|
|
||||||
describe('AP', () => {
|
|
||||||
it('ffVisibility が public 以外ならばAPからは取得できない', async(async () => {
|
|
||||||
{
|
|
||||||
await request('/i/update', {
|
|
||||||
ffVisibility: 'public',
|
|
||||||
}, alice);
|
|
||||||
|
|
||||||
const followingRes = await simpleGet(`/users/${alice.id}/following`, 'application/activity+json');
|
|
||||||
const followersRes = await simpleGet(`/users/${alice.id}/followers`, 'application/activity+json');
|
|
||||||
assert.strictEqual(followingRes.status, 200);
|
|
||||||
assert.strictEqual(followersRes.status, 200);
|
|
||||||
}
|
|
||||||
{
|
|
||||||
await request('/i/update', {
|
|
||||||
ffVisibility: 'followers',
|
|
||||||
}, alice);
|
|
||||||
|
|
||||||
const followingRes = await simpleGet(`/users/${alice.id}/following`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
|
||||||
const followersRes = await simpleGet(`/users/${alice.id}/followers`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
|
||||||
assert.strictEqual(followingRes.status, 403);
|
|
||||||
assert.strictEqual(followersRes.status, 403);
|
|
||||||
}
|
|
||||||
{
|
|
||||||
await request('/i/update', {
|
|
||||||
ffVisibility: 'private',
|
|
||||||
}, alice);
|
|
||||||
|
|
||||||
const followingRes = await simpleGet(`/users/${alice.id}/following`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
|
||||||
const followersRes = await simpleGet(`/users/${alice.id}/followers`, 'application/activity+json').catch(res => ({ status: res.statusCode }));
|
|
||||||
assert.strictEqual(followingRes.status, 403);
|
|
||||||
assert.strictEqual(followersRes.status, 403);
|
|
||||||
}
|
|
||||||
}));
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue