From 5636534d035042bf4f68c0cb666e13235bd85b0b Mon Sep 17 00:00:00 2001 From: Johann150 Date: Tue, 19 Mar 2024 18:07:41 +0100 Subject: [PATCH] server: fix user deletes being stuck in queue The user was already deleted from the user cache, so requesting the user returned null. Because the key was not null, there was a non-null return, in turn making further code think, fetching the user was successful. --- packages/backend/src/remote/activitypub/misc/auth-user.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/backend/src/remote/activitypub/misc/auth-user.ts b/packages/backend/src/remote/activitypub/misc/auth-user.ts index 13140031f..b2901823d 100644 --- a/packages/backend/src/remote/activitypub/misc/auth-user.ts +++ b/packages/backend/src/remote/activitypub/misc/auth-user.ts @@ -35,10 +35,9 @@ export async function authUserFromKeyId(keyId: string): Promise return await publicKeyCache.fetch(keyId) .then(async key => { if (!key) return null; - else return { - user: await userByIdCache.fetch(key.userId), - key, - }; + const user = await userByIdCache.fetch(key.userId); + if (!user) return null; + return { user, key }; }); }