From aac1c406572be4e9161b8adfde299978985ea7e4 Mon Sep 17 00:00:00 2001 From: Johann150 Date: Wed, 24 Jan 2024 01:15:36 +0100 Subject: [PATCH] server: only decrement deletion ref count on final fail Changelog: Fixed --- packages/backend/src/queue/index.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/backend/src/queue/index.ts b/packages/backend/src/queue/index.ts index 182202260..2475d5346 100644 --- a/packages/backend/src/queue/index.ts +++ b/packages/backend/src/queue/index.ts @@ -59,7 +59,11 @@ deliverQueue }) .on('failed', async (job, err) => { deliverLogger.warn(`failed(${err}) ${getJobInfo(job)} to=${job.data.to}`); - await deletionRefCount(job); + + if (job.attemptsMade >= (job.opts?.attempts ?? 1)) { + // this was the last attempt + await deletionRefCount(job); + } }) .on('error', (job: any, err: Error) => deliverLogger.error(`error ${err}`)) .on('stalled', (job) => deliverLogger.warn(`stalled ${getJobInfo(job)} to=${job.data.to}`));