FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

foundkey-js: fix build errors #135

Merged
norm merged 1 commit from fix/foundkeyjs-build-errors into main 2022-09-09 23:08:29 +00:00
Conversation 0 Commits 1 Files changed 3 +170 -26
norm commented 2022-09-09 04:04:55 +00:00
Owner
Copy link

The use of "moduleResolution": "Node16" is to make TS use the same
module resolution as Node does when using ESM modules.

reconnecting-websocket's TS definition files were copied over but
wrapped in a declare module block to make TS properly accept
using the default import directly without using .default.

I also decided to look into autobind-decorator's source code and
figured that I could use the boundMethod annotation directly instead
of using the autobind default export.

The use of `"moduleResolution": "Node16"` is to make TS use the same module resolution as Node does when using ESM modules. `reconnecting-websocket`'s TS definition files were copied over but wrapped in a `declare module` block to make TS properly accept using the default import directly without using `.default`. I also decided to look into `autobind-decorator`'s source code and figured that I could use the `boundMethod` annotation directly instead of using the `autobind` default export.
norm force-pushed fix/foundkeyjs-build-errors from a955333919 to dde6f5eb55 2022-09-09 04:08:39 +00:00 Compare
norm merged commit 12bc89b7ce into main 2022-09-09 23:08:29 +00:00
norm deleted branch fix/foundkeyjs-build-errors 2022-09-09 23:08:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#135
No description provided.
Delete branch "fix/foundkeyjs-build-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?