FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

refactor: token-generate-window.vue to composition api #139

Manually merged
Johann150 merged 1 commit from refactor/token-generate-window.vue into main 2022-09-18 19:13:55 +00:00
Conversation 0 Commits 1 Files changed 1 +60 -87
norm commented 2022-09-10 07:25:10 +00:00
Owner
Copy link
No description provided.
Johann150 reviewed 2022-09-17 21:05:24 +00:00
packages/client/src/components/token-generate-window.vue Outdated
@ -73,0 +40,4 @@
const props = withDefaults(defineProps<{
title?: string;
information?: string;
initialName?: string;
Johann150 commented 2022-09-17 21:03:13 +00:00
Owner
Copy link

These two also need default values or the linter will complain. Probably something like this is appropriate:

information: null,
initialName: '',
These two also need default values or the linter will complain. Probably something like this is appropriate: ``` information: null, initialName: '', ```
norm marked this conversation as resolved
norm force-pushed refactor/token-generate-window.vue from 82dd2f5868 to ff396f4c14 2022-09-17 23:11:42 +00:00 Compare
Johann150 manually merged commit 668181fb44 into main 2022-09-18 19:13:55 +00:00
Johann150 deleted branch refactor/token-generate-window.vue 2022-09-18 19:14:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#130 Refactor remaining client components to SFC Setup + Composition API}
FoundKeyGang/FoundKey
Reference: FoundKeyGang/FoundKey#139
No description provided.
Delete branch "refactor/token-generate-window.vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?