FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client: Fix rollup error "This assignment will throw" #166

Merged
norm merged 1 commit from Michcio/FoundKey-0x7f:fix/this-assignment-will-throw into main 2022-09-20 13:45:45 +00:00
Conversation 3 Commits 1 Files changed 1 +29 -30
Michcio commented 2022-09-20 10:50:27 +00:00
Contributor
Copy link

Mfm cheat sheet was using constants in v-model.
I additionally set the textareas to readonly because now the
examples don't pretend to be interactive anymore.

Mfm cheat sheet was using constants in v-model. I additionally set the textareas to readonly because now the examples don't pretend to be interactive anymore.
Michcio added 1 commit 2022-09-20 10:50:28 +00:00
client: Fix rollup error "This assignment will throw"
Some checks failed
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
9f0f5d1ab1 
Mfm cheat sheet was using constants in v-model.
I additionally set the textareas to readonly because now the
examples don't pretend to be interactive anymore.
norm merged commit b42b6d3d9b into main 2022-09-20 13:45:45 +00:00
Johann150 commented 2022-09-20 17:22:43 +00:00
Owner
Copy link

I think the better solution would have been to make the example strings not constants. The examples were interactive before which I think is a good idea to play around. The interactivity was probably lost when the MFM cheat sheet was refactored to Composition API in cb87d03fe9.

I think the better solution would have been to make the example strings not constants. The examples were interactive before which I think is a good idea to play around. The interactivity was probably lost when the MFM cheat sheet was refactored to Composition API in cb87d03fe9d3ac01af26583d4cc124739d73d59d.
Michcio commented 2022-09-20 17:38:40 +00:00
Author
Contributor
Copy link

Probably then, yeah. But my priority here was to fix them. I'd like to see 0 error builds eventually.

Probably then, yeah. But my priority here was to fix them. I'd like to see 0 error builds eventually.
Michcio deleted branch fix/this-assignment-will-throw 2022-09-20 17:38:53 +00:00
norm commented 2022-09-20 18:11:28 +00:00
Owner
Copy link

I think the better solution would have been to make the example strings not constants. The examples were interactive before which I think is a good idea to play around. The interactivity was probably lost when the MFM cheat sheet was refactored to Composition API in cb87d03fe9.

Should be fixed in #167

> I think the better solution would have been to make the example strings not constants. The examples were interactive before which I think is a good idea to play around. The interactivity was probably lost when the MFM cheat sheet was refactored to Composition API in cb87d03fe9d3ac01af26583d4cc124739d73d59d. Should be fixed in https://akkoma.dev/FoundKeyGang/FoundKey/pulls/167
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#166
No description provided.
Delete branch "Michcio/FoundKey-0x7f:fix/this-assignment-will-throw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?