FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client refactor: remove global variables for i18n #168

Closed
Johann150 wants to merge 1 commit from remove-global-i18n into main
pull from: remove-global-i18n
merge into: FoundKeyGang:main
Conversation 1 Commits 1 Files changed 36 +111 -112
Johann150 commented 2022-09-21 09:12:56 +00:00
Owner
Copy link

This removes the $ts and $t variables that were registered as global in vue. They are identical to i18n.ts and i18n.t respectively.

This removes the `$ts` and `$t` variables that were registered as global in vue. They are identical to `i18n.ts` and `i18n.t` respectively.
Johann150 added 1 commit 2022-09-21 09:12:57 +00:00
remove global variables for i18n
Some checks failed
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
2b4646d250
norm approved these changes 2022-09-21 17:27:52 +00:00
norm commented 2022-09-21 17:30:55 +00:00
Owner
Copy link

merged in 772d4618a6

merged in https://akkoma.dev/FoundKeyGang/FoundKey/commit/772d4618a660c8873e4891845ce85ef751344e35
norm closed this pull request 2022-09-21 17:30:55 +00:00
norm deleted branch remove-global-i18n 2022-09-22 23:04:13 +00:00
Some checks failed
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
norm
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#168
No description provided.
Delete branch "remove-global-i18n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?