FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

Refactor form-dialog.vue to use Composition API #17

Manually merged
Johann150 merged 3 commits from :refactor/form-dialog into main 2022-07-21 19:17:47 +00:00
Conversation 0 Commits 3 Files changed 1 +29 -55
norm commented 2022-07-20 22:16:18 +00:00
Owner
Copy link
No description provided.
norm added 1 commit 2022-07-20 22:16:19 +00:00
Refactor form-dialog.vue to use Composition API
Some checks failed
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
d29a0dad8f
norm added 1 commit 2022-07-20 22:17:28 +00:00
Johann150 reviewed 2022-07-20 23:00:10 +00:00
packages/client/src/components/form-dialog.vue Outdated
@ -89,1 +71,3 @@
},
const props = defineProps<{
title: string,
form: object,
Johann150 commented 2022-07-20 22:58:22 +00:00
Owner
Copy link

I'm not sure object is a type in TypeScript. It is a thing but will cause errors as soon as you ty to access form. I would expect to see any or probably better Record<string, any> here.

~~I'm not sure `object` is a type in TypeScript.~~ It is a thing but will cause errors as soon as you ty to access `form`. I would expect to see `any` or probably better `Record<string, any>` here.
norm commented 2022-07-20 23:25:16 +00:00
Author
Owner
Copy link

Fixed

Fixed
norm marked this conversation as resolved
norm added 1 commit 2022-07-20 23:24:58 +00:00
form-dialog: use Record<string, any> for form prop
Some checks failed
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
2d245d62cf
Johann150 manually merged commit fef2d9173e into main 2022-07-21 19:17:47 +00:00
norm referenced this pull request from a commit 2022-08-28 14:46:46 +00:00
resolve #17
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#17
No description provided.
Delete branch ":refactor/form-dialog"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?