FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client: refactor components/ripple.vue to composition API #181

Manually merged
Johann150 merged 1 commit from refactor/ripple into main 2022-10-02 11:12:47 +00:00
Conversation 0 Commits 1 Files changed 1 +35 -47
Johann150 commented 2022-09-30 15:57:52 +00:00
Owner
Copy link
No description provided.
norm reviewed 2022-10-01 14:37:46 +00:00
packages/client/src/components/ripple.vue Outdated
@ -84,0 +63,4 @@
const props = withDefaults(defineProps<{
x: number;
y: number;
paricle?: boolean;
norm commented 2022-10-01 14:37:46 +00:00
Owner
Copy link

Typo: should be particle

Typo: should be `particle`
Johann150 marked this conversation as resolved
Johann150 force-pushed refactor/ripple from 784b112bea to 5ef9b07eef 2022-10-01 21:02:29 +00:00 Compare
norm requested changes 2022-10-01 21:21:38 +00:00
packages/client/src/components/ripple.vue Outdated
@ -100,0 +72,4 @@
(ev: 'end'): void;
}>();
const zIndex = os.claimZIndex('high'),
norm commented 2022-10-01 21:21:34 +00:00
Owner
Copy link

Comma should be a semicolon instead, this error shows up otherwise:

[vite:vue] [@vue/compiler-sfc] Unexpected keyword 'const'. (18:0)

/home/norm/FoundKey/packages/client/src/components/ripple.vue
73 |  }>();
74 |
75 |  const zIndex = os.claimZIndex('high'),
   |                                         ^
76 |  const particles = [];
   |  ^
77 |  const origin = 64;
Comma should be a semicolon instead, this error shows up otherwise: ``` [vite:vue] [@vue/compiler-sfc] Unexpected keyword 'const'. (18:0) /home/norm/FoundKey/packages/client/src/components/ripple.vue 73 | }>(); 74 | 75 | const zIndex = os.claimZIndex('high'), | ^ 76 | const particles = []; | ^ 77 | const origin = 64; ```
Johann150 marked this conversation as resolved
Johann150 force-pushed refactor/ripple from 5ef9b07eef to 38b006ac2d 2022-10-01 22:10:30 +00:00 Compare
norm approved these changes 2022-10-02 02:49:39 +00:00
norm left a comment
Owner
Copy link

As far as I can tell this looks good now.

As far as I can tell this looks good now.
Johann150 manually merged commit be19ea610f into main 2022-10-02 11:12:47 +00:00
Johann150 deleted branch refactor/ripple 2022-10-02 11:13:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
norm
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#181
No description provided.
Delete branch "refactor/ripple"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?