FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

client: refactor components/tab.vue to composition API #184

Manually merged
Johann150 merged 1 commits from refactor/tab.vue into main 2022-10-04 19:27:07 +00:00
Conversation 0 Commits 1 Files Changed 7 +67 -49
Johann150 commented 2022-10-04 17:59:16 +00:00
Owner
Copy Link

Refactoring this component could be done after changing its method of
receiving the list of available tabs by using slots to using an
ordinary parameter. This was possible because all uses of this
component just provided text as the tab labels.

Also removed unused imports of this component.

Also removed the use of the click-anime directive. This is a prerequisite to removing the whole directive.

Refactoring this component could be done after changing its method of receiving the list of available tabs by using slots to using an ordinary parameter. This was possible because all uses of this component just provided text as the tab labels. Also removed unused imports of this component. Also removed the use of the click-anime directive. This is a prerequisite to removing the whole directive.
Johann150 added 1 commit 2022-10-04 17:59:16 +00:00
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
93f54e3258
client: refactor components/tab.vue to composition API 
Refactoring this component could be done after changing its method of
receiving the list of available tabs by using slots to using an
ordinary parameter. This was possible because all uses of this
component just provided text as the tab labels.

Also removed unused imports of this component.

Also removed the use of the click-anime directive.
Johann150 added a new dependency 2022-10-04 18:03:35 +00:00
#185 client: remove click-anime directive
norm approved these changes 2022-10-04 18:54:13 +00:00
Johann150 manually merged commit 6ef9069a2f into main 2022-10-04 19:27:07 +00:00
Johann150 deleted branch refactor/tab.vue 2022-10-04 19:27:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
norm
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#130 Refactor remaining client components to SFC Setup + Composition API
FoundKeyGang/FoundKey
#185 client: remove click-anime directive
FoundKeyGang/FoundKey
Reference: FoundKeyGang/FoundKey#184
No description provided.
Delete Branch "refactor/tab.vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?