client: refactor components/tab.vue to composition API #184

Manually merged

Johann150 merged 1 commit from refactor/tab.vue into main 2022-10-04 19:27:07 +00:00

Conversation 0 Commits 1 Files changed 7 +67 -49

Johann150 commented 2022-10-04 17:59:16 +00:00

Owner

Copy link

Refactoring this component could be done after changing its method of
receiving the list of available tabs by using slots to using an
ordinary parameter. This was possible because all uses of this
component just provided text as the tab labels.

Also removed unused imports of this component.

Also removed the use of the click-anime directive. This is a prerequisite to removing the whole directive.

Refactoring this component could be done after changing its method of receiving the list of available tabs by using slots to using an ordinary parameter. This was possible because all uses of this component just provided text as the tab labels. Also removed unused imports of this component. Also removed the use of the click-anime directive. This is a prerequisite to removing the whole directive.

Johann150 added 1 commit 2022-10-04 17:59:16 +00:00

client: refactor components/tab.vue to composition API ... 93f54e3258

Refactoring this component could be done after changing its method of
receiving the list of available tabs by using slots to using an
ordinary parameter. This was possible because all uses of this
component just provided text as the tab labels.

Also removed unused imports of this component.

Also removed the use of the click-anime directive.

Johann150 referenced this pull request 2022-10-04 17:59:57 +00:00

Refactor remaining client components to SFC Setup + Composition API #130

Johann150 added a new dependency 2022-10-04 18:00:27 +00:00

#130 Refactor remaining client components to SFC Setup + Composition API

Johann150 added a new dependency 2022-10-04 18:03:35 +00:00

#185 client: remove click-anime directive

norm approved these changes 2022-10-04 18:54:13 +00:00

Johann150 referenced this pull request from a commit 2022-10-04 19:25:44 +00:00

client: refactor components/tab.vue to composition API

Johann150 manually merged commit 6ef9069a2f into main 2022-10-04 19:27:07 +00:00

Johann150 deleted branch refactor/tab.vue 2022-10-04 19:27:46 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

norm

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#130 Refactor remaining client components to SFC Setup + Composition API}

FoundKeyGang/FoundKey

#185 client: remove click-anime directive}

FoundKeyGang/FoundKey

Reference: FoundKeyGang/FoundKey#184

No description provided.