client: remove click-anime directive #185

Merged

norm merged 2 commits from remove-anime into main 2022-10-05 04:41:33 +00:00

Conversation 0 Commits 2 Files changed 19 +106 -135

Johann150 commented 2022-10-04 18:03:20 +00:00

Owner

Copy link

This removes the custom click-anime vue directive which was completely commented out for a while and thus has done nothing since commit 0f736e7e9d by suilo on 2022-03-06.

This removes the custom `click-anime` vue directive which was completely commented out for a while and thus has done nothing since commit 0f736e7e9d3f3d73d866ab4039d83d7d98228e97 by suilo on 2022-03-06.

Johann150 added 2 commits 2022-10-04 18:03:20 +00:00

client: refactor components/tab.vue to composition API ... 93f54e3258

Refactoring this component could be done after changing its method of
receiving the list of available tabs by using slots to using an
ordinary parameter. This was possible because all uses of this
component just provided text as the tab labels.

Also removed unused imports of this component.

Also removed the use of the click-anime directive.

client: remove click-anime directive f4f83cb091

Johann150 added a new dependency 2022-10-04 18:03:35 +00:00

#184 client: refactor components/tab.vue to composition API

norm approved these changes 2022-10-05 04:33:16 +00:00

norm merged commit def5eb0d2e into main 2022-10-05 04:41:33 +00:00

norm referenced this pull request from a commit 2022-10-05 04:41:33 +00:00

Merge pull request 'client: remove click-anime directive' (#185) from remove-anime into main

norm deleted branch remove-anime 2022-10-05 04:41:45 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

norm

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on

#184 client: refactor components/tab.vue to composition API

FoundKeyGang/FoundKey

Reference: FoundKeyGang/FoundKey#185

No description provided.