FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

client: refactor marquee component to composition API #187

Merged
norm merged 2 commits from refactor/marquee into main 2022-10-08 23:00:49 +00:00
Conversation 0 Commits 2 Files Changed 1 +57 -86
Johann150 commented 2022-10-07 11:34:14 +00:00
Owner
Copy Link
No description provided.
Johann150 added 1 commit 2022-10-07 11:34:14 +00:00
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
3f59b7f705
client: refactor marquee component to composition API
norm reviewed 2022-10-08 07:06:42 +00:00
packages/client/src/components/marquee.vue Outdated
@ -33,3 +26,1 @@
}
watch(() => props.duration, calc);
let contentEl = $ref();
norm commented 2022-10-08 07:06:42 +00:00
Owner
Copy Link

This should have a type annotation of HTMLElement.

This should have a type annotation of `HTMLElement`.
Johann150 marked this conversation as resolved
norm reviewed 2022-10-08 07:07:39 +00:00
packages/client/src/components/marquee.vue Outdated
@ -37,3 +28,1 @@
onMounted(() => {
calc();
});
function calc() {
norm commented 2022-10-08 07:07:39 +00:00
Owner
Copy Link

This should have a return type annotation added.

This should have a return type annotation added.
Johann150 marked this conversation as resolved
Johann150 added 1 commit 2022-10-08 18:59:35 +00:00
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
60e49a4196
add type annotations
norm merged commit 4e0f14c0db into main 2022-10-08 23:00:49 +00:00
norm deleted branch refactor/marquee 2022-10-08 23:00:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#130 Refactor remaining client components to SFC Setup + Composition API
FoundKeyGang/FoundKey
Reference: FoundKeyGang/FoundKey#187
No description provided.
Delete Branch "refactor/marquee"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?