FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

refactor: use nullish coalescing & optional chaining #195

Manually merged
norm merged 1 commit from refactor/use-null-coalesce-etc into main 2022-10-10 22:44:51 +00:00
Conversation 0 Commits 1 Files changed 7 +7 -7
Johann150 commented 2022-10-10 21:04:33 +00:00
Owner
Copy link

Changes several places to use the afforementioned constructs in favour of ternary expressions.

Changes several places to use the afforementioned constructs in favour of ternary expressions.
norm reviewed 2022-10-10 22:36:06 +00:00
packages/client/src/scripts/scroll.ts Outdated
@ -13,3 +13,3 @@
export function getScrollPosition(el: Element | null): number {
const container = getScrollContainer(el);
return container == null ? window.scrollY : container.scrollTop;
return container.?scrollTop ?? window.scrollY;
norm commented 2022-10-10 22:36:06 +00:00
Owner
Copy link

I think this is a typo. Should be:

return container?.scrollTop ?? window.scrollY;
I think this is a typo. Should be: ```js return container?.scrollTop ?? window.scrollY; ```
Johann150 marked this conversation as resolved
Johann150 force-pushed refactor/use-null-coalesce-etc from eba9d9cc0f to 808c43377e 2022-10-10 22:39:37 +00:00 Compare
norm manually merged commit 13a3581817 into main 2022-10-10 22:44:51 +00:00
norm deleted branch refactor/use-null-coalesce-etc 2022-10-10 22:45:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#195
No description provided.
Delete branch "refactor/use-null-coalesce-etc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?