client refactor: use pagination in drive component #203
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor-drive"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This majorly refactors the drive component to use the proper pagination component instead of reimplementing pagination.
The drive component is also refactored to use ref sugar (i.e.
$ref
).Something still to fix is the loading of the two pagination components. On the one hand there are two loading spinners
and while they are loading theemptyDrive
message will be shown. The problem is that there is currently no way to tell if a pagination is still loading. Either exposing a property or firing aloaded
event or something like that might be useful but I'm not sure what is the best solution in this case.I think i can live with two loading spinners, so marking this as no longer work in progress.
WIP: client refactor: use pagination in drive componentto client refactor: use pagination in drive component@ -426,0 +448,4 @@
// display new folder hierarchy appropriately
hierarchyFolders = [];
let parent = foldertoMove.parent;
Getting an error here:
Still can't open folders for some reason, though I'm not seeing anything relevant in the browser console.
@ -135,0 +162,4 @@
let hierarchyFolders = $ref<foundkey.entities.DriveFolder[]>([]);
let selectedFiles = $ref<foundkey.entities.DriveFile[]>([]);
let selectedFolders = $ref<foundkey.entities.DriveFolder[]>([]);
let keepOriginal = $ref<boolean>(defaultStore.state.keepOriginalUploading); // 外部渡しが多いので$refは使わないほうがよい
Nitpick: Should probably remove or translate the comment here.
🥴 hmm let me check something
Okay there is 1 place where that needs to be passed as a "proper" ref and that is already covered. Just gonna remove that comment.
Working for me locally on my dev setup. Should be good to go, nitpick aside.