server: improve security of password reset flow #213
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/password-reset"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
NB: This rate limiting is applied per IP address.
NB: This is effectively a rate limit that is applied per user.
The username will be known to the person that requested the reset.
This should serve to reassure users that this is not a phishing mail.
Changelog: Security
Looks good, aside from a minor nitpick (feel free to ignore)
@ -34,1 +37,3 @@
throw new Error(); // TODO
if (req == null) throw new ApiError(meta.errors.noSuchResetRequest);
// Check that the has not expired yet after 30 minutes.
Guessing that the comment meant to say
manually merged in
4dc97d5b65
Pull request closed