client: refactor pagination.vue #216

Manually merged

Johann150 merged 2 commits from refactor-pagination.vue into main 2022-10-29 21:10:51 +00:00

Conversation 2 Commits 2 Files changed 1 +92 -119

norm commented 2022-10-29 02:01:33 +00:00

Owner

Copy link

This mostly involves deduplicating code and removing redudndant
statements.

Also translated all but one comment to English.

This mostly involves deduplicating code and removing redudndant statements. Also translated all but one comment to English.

norm added 1 commit 2022-10-29 02:01:33 +00:00

client: refactor pagination.vue ... 7117e4dadb

This mostly involves deduplicating code and removing redudndant
statements.

Also translated all but one comment to English.

norm added 1 commit 2022-10-29 02:04:47 +00:00

fix conditional dbd02dadd3

Johann150 manually merged commit 4bfbe0dd96 into main 2022-10-29 21:10:51 +00:00

Johann150 deleted branch refactor-pagination.vue 2022-10-29 21:10:56 +00:00

Johann150 commented 2022-10-30 10:03:04 +00:00

Owner

Copy link

We both missed the params thing in fetchMore, it should have been the same as in init. Formatting the ternary statement to have linebreaks in it made it more obvious that something was wrong. Fixed that in 14c7d2bf53.

We both missed the `params` thing in `fetchMore`, it should have been the same as in `init`. Formatting the ternary statement to have linebreaks in it made it more obvious that something was wrong. Fixed that in 14c7d2bf538ac601612b3c8baa9d4c014db4b93b.

👍 1

norm commented 2022-10-30 15:29:27 +00:00

Author

Owner

Copy link

Thanks for catching that.

Thanks for catching that.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#216

No description provided.