FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

Can't install on Node 19.x #238

New issue
Closed
opened 2022-11-17 20:02:45 +00:00 by norm · 4 comments
norm commented 2022-11-17 20:02:45 +00:00
Owner
Copy link

This appears to be caused by the re2 library not being updated for Node 19.

Might be worth considering whether this library is still needed or if we can just use Node's built-in regex support instead.

This appears to be caused by the [`re2` library](https://www.npmjs.com/package/re2) not being updated for Node 19. Might be worth considering whether this library is still needed or if we can just use Node's built-in regex support instead.
norm added this to the (deleted) project 2022-11-17 20:03:19 +00:00
Johann150 commented 2022-11-17 20:40:53 +00:00
Owner
Copy link

Node 19 is not supported per the installation instructions. We should first check/upgrade to Node 18.

Node 19 is not supported per the [installation instructions](https://akkoma.dev/FoundKeyGang/FoundKey/src/branch/main/docs/INSTALL.md#dependencies-package). We should first check/upgrade to Node 18.
norm commented 2022-11-17 21:41:52 +00:00
Author
Owner
Copy link

FoundKey works fine on Node 18.

FWIW, upstream misskey bumped their minimum version to 18.x: 1751bfea5f

FoundKey works fine on Node 18. FWIW, upstream misskey bumped their minimum version to 18.x: https://github.com/misskey-dev/misskey/commit/1751bfea5f49c53c37558e512a83fb03a3231a48
Johann150 commented 2022-11-18 19:58:06 +00:00
Owner
Copy link

Do we know what our current minimum version is? (i.e. full semver node version)

Do we know what our current minimum version is? (i.e. full semver node version)
norm commented 2022-11-18 20:18:32 +00:00
Author
Owner
Copy link

Probably 18.9.0, based on the Dockerfile

Probably 18.9.0, based on the Dockerfile
norm referenced this issue from a commit 2022-11-28 17:03:19 +00:00
backend: update re2 to 1.17.8
norm closed this issue 2022-11-28 17:03:19 +00:00
Johann150 added the
upkeep
 label 2022-12-23 10:23:17 +00:00
Johann150 removed this from the (deleted) project 2022-12-23 10:23:20 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
refactor-deliver-actor
markdown
move-autoblock
feature/requests
context
indicator-circle-v2
v13.0.0-preview6
v13.0.0-preview5.1
v13.0.0-preview5
v13.0.0-preview4
v13.0.0-preview3
v13.0.0-preview2
v13.0.0-preview1
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#238
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?