FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

backend: use upsert to update meta table #239

Closed
norm wants to merge 1 commit from upsert-meta into main
pull from: upsert-meta
merge into: FoundKeyGang:main
Conversation 1 Commits 1 Files changed 1 +1 -1
norm commented 2022-11-17 23:57:00 +00:00
Owner
Copy link

This fixes an issue where the meta table fails to update due to a
duplicate ID.

Changelog: Fixed

This fixes an issue where the meta table fails to update due to a duplicate ID. Changelog: Fixed
norm added 1 commit 2022-11-17 23:57:01 +00:00
backend: use upsert to update meta table
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
bdc0b74499 
This fixes an issue where the meta table fails to update due to a
duplicate ID.
Johann150 commented 2022-11-18 19:53:57 +00:00
Owner
Copy link

Using upsert here is not the correct solution, since clear is suppsed to truncate the table to ensure there is only ever 1 record. The solution was instead to await the truncation. Fixed in commit 28aa440bcc.

Using `upsert` here is not the correct solution, since `clear` is suppsed to truncate the table to ensure there is only ever 1 record. The solution was instead to `await` the truncation. Fixed in commit 28aa440bcc967224964cadf141924f8960409c9a.
Johann150 closed this pull request 2022-11-18 19:53:57 +00:00
norm deleted branch upsert-meta 2022-11-18 20:21:31 +00:00
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#239
No description provided.
Delete branch "upsert-meta"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?