FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

chore: remove some unused locale strings #255

Manually merged
Johann150 merged 1 commit from unused-i18n into main 2022-11-28 18:46:30 +00:00
Conversation 0 Commits 1 Files changed 1 -174
Johann150 commented 2022-11-27 23:09:19 +00:00
Owner
Copy link

I removed some locales that I could not find usages of in the client, backend or service worker. But I'm not sure if I missed a usage so would appreciate someone else checking.

I removed some locales that I could not find usages of in the client, backend or service worker. But I'm not sure if I missed a usage so would appreciate someone else checking.
norm requested changes 2022-11-28 07:19:41 +00:00
norm left a comment
Owner
Copy link

Other than a few places, it seems fine.

Other than a few places, it seems fine.
locales/en-US.yml Outdated
@ -994,4 +883,2 @@
contributors: "Main contributors"
allContributors: "All contributors"
source: "Source code"
translation: "Translate FoundKey"
norm commented 2022-11-28 07:16:44 +00:00
Owner
Copy link

Wondering if we should re-add a link for translating FoundKey...

Wondering if we should re-add a link for translating FoundKey...
Johann150 commented 2022-11-28 17:37:34 +00:00
Author
Owner
Copy link

Mmh yeah didn't think about it, but it was probably just removed because we didn't have weblate set up at that point. Added back in 97233fab69.

Mmh yeah didn't think about it, but it was probably just removed because we didn't have weblate set up at that point. Added back in 97233fab69206d74a8c400f7056139eae0f200f1.
Johann150 marked this conversation as resolved
locales/en-US.yml Outdated
@ -776,4 +682,2 @@
emailNotification: "Email notifications"
publish: "Publish"
inChannelSearch: "Search in channel"
useReactionPickerForContextMenu: "Open reaction picker on right-click"
norm commented 2022-11-28 07:13:38 +00:00
Owner
Copy link

Used here:

Line 29 in 2f56499
<FormSwitch v-model="useReactionPickerForContextMenu" class="_formBlock">{{ i18n.ts.useReactionPickerForContextMenu }}</FormSwitch>

Used here: https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/2f56499445e47e0d7380a6be389b989436eca325/packages/client/src/pages/settings/general.vue#L29
Johann150 marked this conversation as resolved
locales/en-US.yml Outdated
@ -202,4 +179,0 @@
cpuAndMemory: "CPU and Memory"
network: "Network"
disk: "Disk"
instanceInfo: "Instance Information"
norm commented 2022-11-28 07:03:46 +00:00
Owner
Copy link

instanceInfo is used in a few of places:

[norm@mikoto FoundKey]$ rg 'ts\.instanceInfo' packages/
packages/client/src/components/launch-pad.vue
25:                             <div class="text">{{ i18n.ts.instanceInfo }}</div>

packages/client/src/pages/user-info.vue
23:                             <FormLink v-if="user.host" class="_formBlock" :to="`/instance-info/${user.host}`">{{ i18n.ts.instanceInfo }}</FormLink>
49:                                                     <template #key>{{ i18n.ts.instanceInfo }}</template>
53:                                                     <template #key>{{ i18n.ts.instanceInfo }}</template>

packages/client/src/pages/welcome.entrance.a.vue
104:            text: i18n.ts.instanceInfo,

packages/client/src/pages/about.vue
130:    title: i18n.ts.instanceInfo,
`instanceInfo` is used in a few of places: ``` [norm@mikoto FoundKey]$ rg 'ts\.instanceInfo' packages/ packages/client/src/components/launch-pad.vue 25: <div class="text">{{ i18n.ts.instanceInfo }}</div> packages/client/src/pages/user-info.vue 23: <FormLink v-if="user.host" class="_formBlock" :to="`/instance-info/${user.host}`">{{ i18n.ts.instanceInfo }}</FormLink> 49: <template #key>{{ i18n.ts.instanceInfo }}</template> 53: <template #key>{{ i18n.ts.instanceInfo }}</template> packages/client/src/pages/welcome.entrance.a.vue 104: text: i18n.ts.instanceInfo, packages/client/src/pages/about.vue 130: title: i18n.ts.instanceInfo, ```
Johann150 marked this conversation as resolved
locales/en-US.yml Outdated
@ -52,4 +47,2 @@
sendMessage: "Send a message"
copyUsername: "Copy username"
searchUser: "Search for a user"
reply: "Reply"
norm commented 2022-11-28 06:59:06 +00:00
Owner
Copy link

The reply string appears to be used in

Line 191 in 2f56499
? i18n.ts.reply

The `reply` string appears to be used in https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/2f56499445e47e0d7380a6be389b989436eca325/packages/client/src/components/post-form.vue#L191
Johann150 marked this conversation as resolved
Johann150 force-pushed unused-i18n from dd801327f9 to 2d4bc9c268 2022-11-28 17:41:58 +00:00 Compare
norm approved these changes 2022-11-28 18:36:15 +00:00
Johann150 manually merged commit a6a4ae870d into main 2022-11-28 18:46:30 +00:00
Johann150 deleted branch unused-i18n 2022-11-28 18:46:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
norm
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#255
No description provided.
Delete branch "unused-i18n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?