BREAKING: server: remove wildcard blocking and instead block subdomains #269

Merged

norm merged 4 commits from subdomain-blocking into main 2022-12-05 17:55:38 +00:00

Conversation 3 Commits 4 Files changed 9 +30 -44

norm commented 2022-12-03 11:59:22 +00:00

Owner

Copy link

Supercedes #268 and #266.

Supercedes #268 and #266.

norm added 1 commit 2022-12-03 11:59:22 +00:00

server: move shouldBlockInstance to separate file b7f6ed9c84

norm referenced this pull request 2022-12-03 11:59:33 +00:00

server: block subdomains of blocked hosts #266

norm referenced this pull request 2022-12-03 11:59:52 +00:00

server: make more places wildcard block-aware #268

norm force-pushed subdomain-blocking from 2ea5aa597b to 52c96e96cf 2022-12-03 12:04:10 +00:00 Compare

Johann150 requested changes 2022-12-03 12:36:40 +00:00

Johann150 left a comment

Owner

Copy link

1. Locale needs to be updated again.
2. Because we've already release this now, do we need a migration?

1. Locale needs to be updated again. 2. Because we've already release this now, do we need a migration?

👍 2

norm added 1 commit 2022-12-03 18:33:26 +00:00

update blockedInstancesDescription string 909c815dab

norm commented 2022-12-03 18:34:55 +00:00

Author

Owner

Copy link

If it's possible, we could try doing a migration to strip out wildcards.

If it's possible, we could try doing a migration to strip out wildcards.

norm commented 2022-12-03 19:09:49 +00:00

Author

Owner

Copy link

Hmm... but on the other hand if the wildcard is in the middle of the string, that would require manual intervention.

If that's the case, I do kinda think we should just make a notice that admins need to update their blocked instances list before updating.

Hmm... but on the other hand if the wildcard is in the middle of the string, that would require manual intervention. If that's the case, I do kinda think we should just make a notice that admins need to update their blocked instances list before updating.

norm commented 2022-12-05 05:51:46 +00:00

Author

Owner

Copy link

Per discussion in #foundkey-dev, there will be no migration. Admins will need to manually update wildcard entries upon updating.

Per discussion in #foundkey-dev, there will be no migration. Admins will need to manually update wildcard entries upon updating.

norm changed title from server: remove wildcard blocking and instead block subdomains to BREAKING: server: remove wildcard blocking and instead block subdomains 2022-12-05 07:54:27 +00:00

toast approved these changes 2022-12-05 14:59:22 +00:00

toast left a comment

Owner

Copy link

there's some optimization to maybe be done later, but for now LGTM

there's some optimization to maybe be done later, but for now LGTM

norm merged commit c1a51547a9 into main 2022-12-05 17:55:38 +00:00

norm deleted branch subdomain-blocking 2022-12-05 17:55:38 +00:00

norm referenced this pull request from a commit 2022-12-05 17:55:39 +00:00

BREAKING: server: remove wildcard blocking and instead block subdomains (#269)

Sign in to join this conversation.

Reviewers

No reviewers

Johann150

toast

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#269

No description provided.