Add federation action hints instead of login prompts

pixeldesu commented

2022-12-11 00:36:42 +00:00

Owner

I know that I was the person that added the login prompts, but that was still a better solution than API errors.

Something similar like this for actions in FoundKey would improve usability greatly.

_I know that I was the person that added the login prompts, but that was still a better solution than API errors._ Something similar like this for actions in FoundKey would improve usability greatly. ![image](/attachments/89b1f7ca-024e-4cb6-a2fd-e8d25f59321c)

image.png

65 KiB

pixeldesu referenced this issue

2022-12-11 00:39:35 +00:00

Show follow button to logged out users #280

Johann150 commented

2022-12-11 16:51:14 +00:00

Owner

see also https://github.com/misskey-dev/misskey/issues/8806

Johann150 added the

feature

label 2022-12-23 10:29:53 +00:00

Johann150 added a new dependency 2023-02-18 12:08:00 +00:00

#280 Show follow button to logged out users

Johann150 commented

2023-02-27 16:03:25 +00:00

Owner

The Misskey issue I linked above assumes usage of the ostatus authorize-follow endpoint. However as can be seen from the screenshot above, Mastodon does not seem to use this any more. Instead it just offers a URL, probably the Activitypub url (using id as fallback would be a good idea). This should be much easier to implement.

The Misskey issue I linked above assumes usage of the ostatus `authorize-follow` endpoint. However as can be seen from the screenshot above, Mastodon does not seem to use this any more. Instead it just offers a URL, probably the Activitypub `url` (using `id` as fallback would be a good idea). This should be much easier to implement.

Johann150 self-assigned this 2023-02-27 16:03:40 +00:00

Johann150 commented

2023-03-03 17:47:41 +00:00

Owner

I've been trying a few different things. Here is a screenshot of my current state:

What I would like to highlight about this is that the dialog assumes that you need to go to a different instance (as opposed to the dialog from Mastodon shown above). Therefore, copying the URL is the first option and highlighted. This is because:

If you are on your instance, you are most likely already logged in and will never see this dialog.
Since Foundkey is intended more for smaller instances, there will always be many more people on another instance than on the local instance.

The dialog also does not feature a sign up button because of point 2 above. In my opinion it is also unlikely that someone will randomly wander onto an instances page, click an interaction button and then want to create an account. If they really want they can close the dialog and use the "sign up" button that you can see in the background, which would be easier to reach without opening the dialog.

One thing to maybe add though is a "cancel" button next to the sign in button. Though technically you can achieve the same thing by closing the dialog normally.

I've been trying a few different things. Here is a screenshot of my current state: ![image](/attachments/e89ad8b6-0e7a-4fdc-ae20-e154639a0604) What I would like to highlight about this is that the dialog assumes that you need to go to a different instance (as opposed to the dialog from Mastodon shown above). Therefore, copying the URL is the first option and highlighted. This is because: 1. If you are on your instance, you are most likely already logged in and will never see this dialog. 2. Since Foundkey is intended more for smaller instances, there will always be many more people on another instance than on the local instance. The dialog also does not feature a sign up button because of point 2 above. In my opinion it is also unlikely that someone will randomly wander onto an instances page, click an interaction button and *then* want to create an account. If they *really want* they can close the dialog and use the "sign up" button that you can see in the background, which would be easier to reach without opening the dialog. One thing to maybe add though is a "cancel" button next to the sign in button. Though technically you can achieve the same thing by closing the dialog normally.

image.png

48 KiB

pixeldesu commented

2023-03-03 18:08:49 +00:00

Author

Owner

First of all: This looks nice!

Like it more than my approach which was more of a carbon copy of the Mastodon one (minus good texting).

Some points though:

"And you are...?" as a heading kinda has some kind of...passive-aggressive tone to it? We should probably just go for something general or no heading at all.
"If you paste it into the search field on your instance, you should be taken to the right location." for what? It would be better to word it something along the lines of "...you should be able to find and interact with this post" to be more specific.
It's the correct term for it, but I think we can drop the "URL of this object" label to make it less technical.
Please indeed add a cancel button next to the sign in one, the action be visible for users quicker that way.

> ![image](/attachments/e89ad8b6-0e7a-4fdc-ae20-e154639a0604) First of all: This looks nice! Like it more than my approach which was more of a carbon copy of the Mastodon one (minus good texting). Some points though: * "And you are...?" as a heading kinda has some kind of...passive-aggressive tone to it? We should probably just go for something general or no heading at all. * "If you paste it into the search field on your instance, you should be taken to the right location." *for what?* It would be better to word it something along the lines of "...you should be able to find and interact with this post" to be more specific. * It's the correct term for it, but I think we can drop the "URL of this object" label to make it less technical. * Please indeed add a cancel button next to the sign in one, the action be visible for users quicker that way.

Johann150 commented

2023-03-03 18:44:50 +00:00

Owner

~~I agree, though I'm bad at coming up with a better title, hence the current one. No title is not really an option because the dialog component would have to be rewritten to allow that.~~ Title has been replaced. Since there were no other suggestions, I picked one. (59a7f10fdc)
The dialog is ambiguous on purpose, and it has to be because it can and will be used for different things. 👉 #280
~~So you mean no label at all? Or just a shorter label, maybe just "URL"? (Similar problem to 1. because its using a preexisting component.)~~ Has been rewritten without using that component, so there is no more label.
~~Gonna do that.~~ Done.

1. ~~I agree, though I'm bad at coming up with a better title, hence the current one. No title is not really an option because the dialog component would have to be rewritten to allow that.~~ Title has been replaced. Since there were no other suggestions, I picked one. (59a7f10fdc4395febb295cc0387a71de941b8a13) 2. The dialog is ambiguous on purpose, and it has to be because it can and will be used for different things. 👉 #280 3. ~~So you mean no label at all? Or just a shorter label, maybe just "URL"? (Similar problem to 1. because its using a preexisting component.)~~ Has been rewritten without using that component, so there is no more label. 4. ~~Gonna do that.~~ Done.

Johann150 added reference remote-interact

2023-03-03 23:38:15 +00:00

Johann150 commented

2023-03-05 14:46:17 +00:00

Owner

updated screenshot