default reply visibility is bugged #28
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
My private account has "default visibility: followers" and "remembering" turned off (it does this with it on as well).
When replying to an unlisted post, it sets the visibility of my reply to unlisted.
The algorithm should be
most-restrictive(your-default, replied-to-post).I'm not sure where this is, but making this so I remember to look for it later.
Maybe we should include in this that you shouldn't be able to reply with a more open scope. E.g. replying to a DM with public scope should not even be allowed by the API.
The API now enforces that the visibility is not more open than the replied to or quoted note. (commit
40d9aa6219)In that commit I also removed some backend code that set the visibility to home when you replied to a non-public post with a public post. Maybe that is related to the weirdness experienced.
Now, the client should be changed in such a way that
I'll try and look into it asaic - but the backend enforcement is a good start!
Ok, looks like the correct spot for this is components/post-form.vue - specifically the
let visibilitypart.This code is weird, so I might try and refactor it wholly after I figure out what's going on.
#67 implements this
this is left to do
fixed in
338e898f56