FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

configurable error images #282

Manually merged
Johann150 merged 5 commits from config-images into main 2022-12-13 19:56:16 +00:00
Conversation 1 Commits 5 Files Changed 18 +61 -15
Johann150 commented 2022-12-12 19:40:23 +00:00
Owner
Copy Link

This adds configurable error images. The error images are configurable through the config file.

Since the error image paths are also put into HTML templates which will most likely be cached, it seems sensible to require a restart for these changes to take effect, hence in the config file and not in the admin UI.

The default images are now referring to twemoji served directly from the instance itself.

If you wanted to retain the previous images, you can use this configuration:

images:
  info: https://xn--931a.moe/assets/info.jpg
  notFound: https://xn--931a.moe/assets/not-found.jpg
  error: https://xn--931a.moe/assets/error.jpg
This adds configurable error images. The error images are configurable through the config file. Since the error image paths are also put into HTML templates which will most likely be cached, it seems sensible to require a restart for these changes to take effect, hence in the config file and not in the admin UI. The default images are now referring to twemoji served directly from the instance itself. If you wanted to retain the previous images, you can use this configuration: ```yaml images: info: https://xn--931a.moe/assets/info.jpg notFound: https://xn--931a.moe/assets/not-found.jpg error: https://xn--931a.moe/assets/error.jpg ```
Johann150 added 4 commits 2022-12-12 19:40:23 +00:00
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline failed Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
bdf48be473
foundkey-js: adjust type definition
Johann150 added this to the (deleted) project 2022-12-12 21:13:44 +00:00
toast commented 2022-12-13 19:22:16 +00:00
Owner
Copy Link

LGTM - particularly how you can have a relative path to make it be a local source.

LGTM - particularly how you can have a relative path to make it be a local source.
Johann150 added 1 commit 2022-12-13 19:54:11 +00:00
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline failed Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
e43c9278de
fixup: improve docs
Johann150 manually merged commit 73f81177b4 into main 2022-12-13 19:56:16 +00:00
Johann150 deleted branch config-images 2022-12-13 19:56:37 +00:00
Johann150 added the
feature
 label 2022-12-23 10:16:16 +00:00
Johann150 removed this from the (deleted) project 2022-12-23 10:16:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#282
No description provided.
Delete Branch "config-images"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?