FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

sw: add TypeScript type checking #284

Merged
norm merged 1 commit from sw-lint into main 2022-12-13 20:52:55 +00:00
Conversation 1 Commits 1 Files changed 11 +120 -35
norm commented 2022-12-13 20:42:34 +00:00
Owner
Copy link

This implements the upstream changes from
https://github.com/misskey-dev/misskey/pull/9314 but updated to our
version of ESLint.

Also updates TypeScript to 4.9.4 for all packages.

This implements the upstream changes from https://github.com/misskey-dev/misskey/pull/9314 but updated to our version of ESLint. Also updates TypeScript to 4.9.4 for all packages.
norm added 1 commit 2022-12-13 20:42:34 +00:00
sw: add TypeScript type checking
Some checks failed
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-sw Pipeline failed
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-sw Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
6bba55c196 
This implements the upstream changes from
https://github.com/misskey-dev/misskey/pull/9314 but updated to our
version of ESLint.

Also updates TypeScript to 4.9.4 for all packages.
norm commented 2022-12-13 20:43:35 +00:00
Author
Owner
Copy link

This does spit out a lot of errors in the lint output, but that I think should be left to another PR.

I did fix some minor lints however.

This does spit out a lot of errors in the lint output, but that I think should be left to another PR. I did fix some minor lints however.
Johann150 approved these changes 2022-12-13 20:48:31 +00:00
Johann150 left a comment
Owner
Copy link

looks good to me

looks good to me
norm merged commit 6bba55c196 into main 2022-12-13 20:52:55 +00:00
norm deleted branch sw-lint 2022-12-13 20:52:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#284
No description provided.
Delete branch "sw-lint"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?