FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

Internal error occurred in notes/replies: getNote is not defined #286

New issue
Closed
opened 2022-12-14 16:59:14 +00:00 by dwarf · 3 comments
dwarf commented 2022-12-14 16:59:14 +00:00
Contributor
Copy link

When trying to open a note from the timeline in an app like SubwayTooter the following message shows up in the logs:

Dec 14 17:52:54 foundkey[2799539]: ERR  * [api] Internal error occurred in notes/replies: getNote is not defined

This error happens on line 34 of packages/backend/built/server/api/endpoints/notes/replies.js

I'm on the main branch, commit e28a9eb8e8 - I suspect this regression was caused by d4d1e03479

When trying to open a note from the timeline in an app like SubwayTooter the following message shows up in the logs: ``` Dec 14 17:52:54 foundkey[2799539]: ERR * [api] Internal error occurred in notes/replies: getNote is not defined ``` This error happens on line 34 of `packages/backend/built/server/api/endpoints/notes/replies.js` I'm on the main branch, commit e28a9eb8e87b65e2d700c8c268f2cf89b5060804 - I suspect this regression was caused by d4d1e03479f948af7453a340878b3281e9d0faff
Johann150 commented 2022-12-14 17:10:29 +00:00
Owner
Copy link

Thanks for the detailed report!

Also your suspicion was right. Maybe another time you can try coming up with a fix? 😉

Thanks for the detailed report! Also your suspicion was right. Maybe another time you can try coming up with a fix? 😉
dwarf commented 2022-12-14 17:11:25 +00:00
Author
Contributor
Copy link

I would if my javascript skills were any better :(

I would if my javascript skills were any better :(
dwarf commented 2022-12-14 17:24:00 +00:00
Author
Contributor
Copy link

I've updated and this does indeed fix the issue I was having, thanks!

I've updated and this does indeed fix the issue I was having, thanks!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
refactor-deliver-actor
markdown
move-autoblock
feature/requests
context
indicator-circle-v2
v13.0.0-preview6
v13.0.0-preview5.1
v13.0.0-preview5
v13.0.0-preview4
v13.0.0-preview3
v13.0.0-preview2
v13.0.0-preview1
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#286
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?