Improve password hashing algorithm being used #302

New issue

Closed

opened 2022-12-25 20:28:51 +00:00 by norm · 2 comments

norm commented

2022-12-25 20:28:51 +00:00

Owner

Currently FoundKey uses bcrypt with the input cost set to 8 (as seen here).

Bcrypt is however not designed to be resistant to GPU and ASIC password crackers. Moreover, it also has limitations like truncating the input to 72 bytes.

We could possibly move to something more modern like Argon2i or Argon2id, though we do have to make sure existing bcrypt password hashes can still work at least for now.

Currently FoundKey uses bcrypt with the input cost set to 8 (as seen [here](https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/114d416de0b5b5f3635503a44ed9e4454102b7f7/packages/backend/src/misc/password.ts)). Bcrypt is however not designed to be resistant to GPU and ASIC password crackers. Moreover, it also has limitations like truncating the input to 72 bytes. We could possibly move to something more modern like Argon2i or Argon2id, though we do have to make sure existing bcrypt password hashes can still work at least for now.

norm added the

feature

label 2022-12-26 15:58:04 +00:00

toast commented

2022-12-28 17:17:37 +00:00

Owner

Implemented in #308 - which implements Argon2id, still allows logins with bcrypt passwords, and automatically rehashes on sign-in (though not other password-verification cases).

👍 1