Registry items could get duplicated #335

New Issue

Closed

opened 2023-02-02 16:14:39 +00:00 by yanchan09 · 1 comment

yanchan09 commented

2023-02-02 16:14:39 +00:00

A friend of mine had issue with the "How to use FoundKey" tutorial reappearing every page load, even after completing the tutorial.

They managed to resolve the issue by calling i/registry/remove endpoint with the tutorial key ~10 times, until NO_SUCH_KEY error.

Frontend fetches the registry keys from i/registry/get-all endpoint, which returns every key only once (keeping only the last entry!). Meanwhile i/registry/set only updates the first entry in the database.

I'm not sure how the registry keys got duplicated in the first place, though... In theory be30e70344/packages/backend/src/server/api/endpoints/i/registry/set.ts (L25) has a race condition, where multiple keys could be inserted (not updated), but it shouldn't be able to be triggered that easily (to accumulate 10 duplicate keys).

A friend of mine had issue with the "How to use FoundKey" tutorial reappearing every page load, even after completing the tutorial. They managed to resolve the issue by calling `i/registry/remove` endpoint with the `tutorial` key ~10 times, until `NO_SUCH_KEY` error. Frontend fetches the registry keys from `i/registry/get-all` endpoint, which returns every key only once (keeping only the last entry!). Meanwhile `i/registry/set` only updates the first entry in the database. I'm not sure how the registry keys got duplicated in the first place, though... In theory https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/be30e70344cb2862b4397ce0a5927dfda0014c2d/packages/backend/src/server/api/endpoints/i/registry/set.ts#L25 has a race condition, where multiple keys could be inserted (not updated), but it shouldn't be able to be triggered that easily (to accumulate 10 duplicate keys).