Unable to send files in notes from different account

jeder commented

2023-02-15 13:09:13 +00:00

Contributor

Log in to another account in frontend
Choose the other account in the "Create note" modal
Attach a file to the note, and send it

Expected behaviour: Note is sent by another account with a file attached, said file shows up at their drive

Current behaviour: Note is sent by another account without any files attached, said file shows up at the drive of current user

1. Log in to another account in frontend 2. Choose the other account in the "Create note" modal 3. Attach a file to the note, and send it Expected behaviour: Note is sent by another account with a file attached, said file shows up at their drive Current behaviour: Note is sent by another account without any files attached, said file shows up at the drive of current user

Johann150 commented

2023-02-15 18:17:36 +00:00

Owner

Mmh this seems to also not be changed in Misskey (only checked the respective source file, didn't search for related issues). To fix this would also mean that the whole selecting a file thingy needs to switch to another account's drive as well. In all I think it would be a bit complex to fix.

Alternatively maybe we should consider if we should...

allow users to use drive files of another user
This is probably not a good idea, and also is not what was expected.
remove the account switcher in the posting form altogether in favour of the overall account switcher
This would probably be annoying if you just wanted to make a short post on the other account and have to reload the entire frontend to switch accounts.
disallow drive attachments when using the account switcher in the posting form
This would be kinda annoying but you could still use the overall account switcher to post with attachments from another account. And of course as opposed to the previous item it would still allow you to quickly post something from another account (just not with attached files).

Other things that should also be considered: What happens if you already attached a file and then change account? Should the attachments be removed or should you not be allowed to change accounts while files are attached?

Mmh this seems to also not be changed in Misskey (only checked the respective source file, didn't search for related issues). To fix this would also mean that the whole selecting a file thingy needs to switch to another account's drive as well. In all I think it would be a bit complex to fix. Alternatively maybe we should consider if we should... 1. allow users to use drive files of another user This is probably not a good idea, and also is not what was expected. 2. remove the account switcher in the posting form altogether in favour of the overall account switcher This would probably be annoying if you just wanted to make a short post on the other account and have to reload the entire frontend to switch accounts. 3. disallow drive attachments when using the account switcher in the posting form This would be kinda annoying but you could still use the overall account switcher to post with attachments from another account. And of course as opposed to the previous item it would still allow you to quickly post something from another account (just not with attached files). Other things that should also be considered: What happens if you already attached a file and then change account? Should the attachments be removed or should you not be allowed to change accounts while files are attached?

jeder commented

2023-02-17 12:01:22 +00:00

Author

Contributor

I thought that i already answered 🥴 Anyway

What happens if you already attached a file and then change account?

Posting form remains the same, everything stays there, post is sent without a file, just as if you changed the account in the form

Should the attachments be removed or should you not be allowed to change accounts while files are attached?

I think there should be like a warning showing up when you have attached a file, and are trying to change account, that attachments won't be sent (with like OK/Cancel + Don't show again or whatever), and by that IMO option 3 would be the best alternative for the fix

I thought that i already answered 🥴 Anyway >What happens if you already attached a file and then change account? Posting form remains the same, everything stays there, post is sent without a file, just as if you changed the account in the form >Should the attachments be removed or should you not be allowed to change accounts while files are attached? I think there should be like a warning showing up when you have attached a file, and are trying to change account, that attachments won't be sent (with like OK/Cancel + Don't show again or whatever), and by that IMO option 3 would be the best alternative for the fix

Johann150 referenced this issue from a commit

2023-02-18 11:31:57 +00:00

client: fix attached files and account switcher combination

Johann150 closed this issue

2023-02-18 11:31:57 +00:00

Johann150 commented

2023-02-18 11:32:49 +00:00

Owner

The fix above will set the respective other button to disabled (e.g. disable account switcher when files are attached). The tooltip will explain why the button is disabled.

Unable to send files in notes from different account #342