FE sometimes shows unread mentions/notifications that don’t exist #364

Open
opened 2023-03-21 19:48:05 +00:00 by mia · 1 comment
Contributor

This has been a long-standing Misskey bug. Sometimes I get the “unread stuff” dot on the Mentions and Notifications menu entries, but nothing unread actually exists. The only way to clear this is to mark all notes/notifications as read in the FE settings.

I wonder if deleted notes/reactions/renotes never get removed from this. Never tried to test/reproduce this…

This has been a long-standing Misskey bug. Sometimes I get the “unread stuff” dot on the Mentions and Notifications menu entries, but nothing unread actually exists. The only way to clear this is to mark all notes/notifications as read in the FE settings. I wonder if deleted notes/reactions/renotes never get removed from this. Never tried to test/reproduce this…
Owner

What may definitely happen is when deleting notes we do not check if there were any outstanding notifications for that note, and thus will not send an event on the streaming API. That would fix itself on a page reload.

There are foreign key relations with ON DELETE CASCADE in place between note_unread, notification and note. So when a Note is deleted, Notifications referencing it and "unread markers" will be deleted as well.

I do not think there is cascade-deletion in effect though.

What may definitely happen is when deleting notes we do not check if there were any outstanding notifications for that note, and thus will not send an event on the streaming API. That would fix itself on a page reload. There are foreign key relations with `ON DELETE CASCADE` in place between `note_unread`, `notification` and `note`. So when a Note is deleted, Notifications referencing it and "unread markers" will be deleted as well. I do not think there is cascade-deletion in effect though.
Johann150 added the
fix
label 2023-03-21 19:59:10 +00:00
Sign in to join this conversation.
No labels
feature
fix
upkeep
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#364
No description provided.