FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

simplify ID generation #4

Merged
toast merged 3 commits from simplify-id-gen into main 2022-07-13 21:30:21 +00:00
Conversation 2 Commits 3 Files changed 8 +19 -139
Johann150 commented 2022-07-11 14:48:00 +00:00
Owner
Copy link

Simplify ID generation: Only the aid generation algorithm will be supported going forward.

TODO:

  • changelog entry (blocked by contribution guide rewrite)
Simplify ID generation: Only the `aid` generation algorithm will be supported going forward. TODO: - [ ] changelog entry (blocked by contribution guide rewrite)
Johann150 added 3 commits 2022-07-11 14:48:00 +00:00 
Although these are configurable, there seems to be no benefit of being
able to configure these. The expected use of configuration methods other
than "aid" is expected to be low.
Johann150 changed title from simplify-id-gen to simplify ID generation 2022-07-11 14:49:23 +00:00
toast commented 2022-07-11 15:59:25 +00:00
Owner
Copy link

RFC - anyone in the foundkey bubble using other ID generation options?
I don't expect this to be the case, but it makes sense to check just in case.

RFC - anyone in the foundkey bubble using other ID generation options? I don't expect this to be the case, but it makes sense to check just in case.
norm commented 2022-07-13 21:05:22 +00:00
Owner
Copy link

honestly don't think there's much of a bennefit to using a different ID generation algorithm, I've left mine at aid

honestly don't think there's much of a bennefit to using a different ID generation algorithm, I've left mine at `aid`
toast merged commit e9b11231ff into main 2022-07-13 21:30:21 +00:00
Johann150 deleted branch simplify-id-gen 2022-07-13 21:34:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#4
No description provided.
Delete branch "simplify-id-gen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?