custom mfm in emoji have diffrent height than upstream, breaking "advanced" mfm federation #401

New Issue

Closed

opened 2023-07-05 12:26:10 +00:00 by remi · 2 comments

remi commented

2023-07-05 12:26:10 +00:00

Contributor

tl;dr: https://misskey.heonian.org/notes/9gt73emxs9 https://misskey.heonian.org/notes/9gt7ca1ksl https://misskey.heonian.org/notes/9gt7ifi9ta
change d3eb6a3340/packages/client/src/components/global/emoji.vue (L56) this line to say 2.0 instead of 2.5 cuz at some point misskey upstream changed it to 2.0 🥺

At some point, upstream misskey changed the size of custom emoji to be 2.0 in height instead of 2.5. Usually this is not noticable, but in notes with advanced MFM usage, like $[position and $[scale, this ends up being quite noticable (see linked notes above).

Since the new MFM features were taken from misskey13, it feels right that this would be synced so notes with MFM federating from misskey13 appear correctly?

tl;dr: https://misskey.heonian.org/notes/9gt73emxs9 https://misskey.heonian.org/notes/9gt7ca1ksl https://misskey.heonian.org/notes/9gt7ifi9ta change https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/d3eb6a33409b9c22431a655bfc8aa797331abff7/packages/client/src/components/global/emoji.vue#L56 this line to say 2.0 instead of 2.5 cuz at some point misskey upstream changed it to 2.0 🥺 At some point, upstream misskey changed the size of custom emoji to be 2.0 in height instead of 2.5. Usually this is not noticable, but in notes with advanced MFM usage, like `$[position` and `$[scale`, this ends up being quite noticable (see linked notes above). Since the new MFM features were taken from misskey13, it feels right that this would be synced so notes with MFM federating from misskey13 appear correctly?

Johann150 commented

2023-07-07 17:46:03 +00:00

Owner

If you already know what the necessary change is, why don't you make a pull request? :)

For reference the respective Misskey commit is https://github.com/misskey-dev/misskey/commit/c174f233894f2b610908bab659a76bafc8d80ed8.

If you already know what the necessary change is, why don't you make a pull request? :) For reference the respective Misskey commit is <https://github.com/misskey-dev/misskey/commit/c174f233894f2b610908bab659a76bafc8d80ed8>.