Question about array of activities with Tombstone/Delete #411
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi folks,
I've been getting activities from FoundKey and noticed that the Tombstone/Deletes are always packed in an array, like so:
I think this comes from the following line of code:
deliverMultipleToRelays(fetchedUser, content),I'm trying to understand if this is allowed ActivityPub behavior or a bug somewhere. I've read the relevant specs but can't find anything about sending arrays of activities. Would you be able to help me with clarifying the behavior here?
Thank you for your time and have a nice day! 👋
I've noticed this behaviour from the particular instance you show in your example (
wake.0am.jp) too since a while, but I am not sure where it is coming from. I would classify this as a bug and not in line with the ActivityStreams Technical Recommendation.I'm guessing this might be the case because the particular instance is stuck on some broken older version/commit of Foundkey or perhaps they cherry-picked some commits while leaving out others. In particular, they might be missing commit
1bce487965.As a more technical explanation: Foundkey in some cases, like deletion of notes, internally groups activities for delivery. This is done by handing an array of activities to the delivery queue. This mechanism is the same for
DeliveryManager.executeanddeliverMultipleToRelays, since in the end they both insert things into the delivery queue (using thedeliverfunction).Though the queue worker upon seeing an array should deliver all the activities in separate requests, as implemented in the commit mentioned above. The intended advantage is to use keep-alive HTTP connections more effectively.
Oh, understood! That explains why I couldn't find the exact issue in your recent codebase 😅
So I guess this issue is solved and I'm going to close it.
Much appreciated you taking the time to thoroughly explain it 🙇♂️
Have a great day! 👋