refactor: remove note.mentionedRemoteUsers column #84

Closed

Johann150 wants to merge 6 commits from refactor/mentionedRemoteUsers into main

pull from: refactor/mentionedRemoteUsers

merge into: FoundKeyGang:main

FoundKeyGang:main

FoundKeyGang:refactor-deliver-actor

FoundKeyGang:markdown

FoundKeyGang:move-autoblock

FoundKeyGang:feature/requests

FoundKeyGang:context

FoundKeyGang:indicator-circle-v2

Conversation 1 Commits 6 Files changed 9 +69 -74

Johann150 commented 2022-08-24 22:15:07 +00:00

Owner

Copy link

The note.mentionedRemoteUsers column contains data which is duplicated from the note.mentions column and "cached"(?) from the user and user_profile table. Furthermore, the column is marked as text data type when it obvously contains JSON data. Since it is only used in a few places it seems to make more sense to query the database for this information instead of storing this redundant data.

The `note.mentionedRemoteUsers` column contains data which is duplicated from the `note.mentions` column and "cached"(?) from the `user` and `user_profile` table. Furthermore, the column is marked as `text` data type when it obvously contains JSON data. Since it is only used in a few places it seems to make more sense to query the database for this information instead of storing this redundant data.

norm force-pushed refactor/mentionedRemoteUsers from 63cc4f3a6b to aa80de1de8 2022-08-28 18:09:34 +00:00 Compare

norm added 1 commit 2022-08-28 19:01:25 +00:00

fix: migration revert syntax deb7b105f4

norm approved these changes 2022-09-07 07:53:39 +00:00

Johann150 commented 2022-09-07 12:50:04 +00:00

Author

Owner

Copy link

manually merged as 3bdbbcadd9 and 7a981de883 (squashed the fixup commits)

manually merged as 3bdbbcadd9772818c00339faa17e0f4a71dda6bc and 7a981de88331de83152fe0224f9332fffe8a43bb (squashed the fixup commits)

Johann150 closed this pull request 2022-09-07 12:50:10 +00:00

norm referenced this pull request 2022-09-12 20:37:46 +00:00

backend: fix toHtml tests #151

norm referenced this pull request from a commit 2022-09-12 20:38:28 +00:00

backend: make toHtml tests async

norm referenced this pull request from a commit 2022-09-13 15:20:06 +00:00

backend: make toHtml tests async

norm referenced this pull request from a commit 2022-09-13 15:20:27 +00:00

backend: make toHtml tests async

Some checks failed

Hide all checks

ci/woodpecker/pr/lint-backend Pipeline failed

Details

ci/woodpecker/pr/build Pipeline was successful

Details

ci/woodpecker/pr/lint-client Pipeline failed

Details

ci/woodpecker/pr/test Pipeline failed

Details

ci/woodpecker/push/lint-foundkey-js Pipeline was successful

Details

ci/woodpecker/push/lint-backend Pipeline was successful

Details

ci/woodpecker/push/lint-client Pipeline was successful

Details

ci/woodpecker/push/build Pipeline was successful

Details

ci/woodpecker/push/test Pipeline was successful

Details

ci/woodpecker/pr/lint-foundkey-js Pipeline was successful

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

norm

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#84

No description provided.