backend: try to remove ms dependency #9

New Issue

Closed

opened 2022-07-13 15:50:20 +00:00 by Johann150 · 1 comment

Johann150 commented

2022-07-13 15:50:20 +00:00

Owner

ms is a package to convert string representations to a number of milliseconds, e.g. convert '1h' to 3_600_000. Having this dependency seems unnecessary.

I'm not sure if we should directly hard code the numbers with a comment next to them or have a file with a bunch of constants like this:

export const SECOND = 1000;
export const MINUTE = 60 * SEC;
export const HOUR = 60 * MIN;

`ms` is a package to convert string representations to a number of milliseconds, e.g. convert `'1h'` to `3_600_000`. Having this dependency seems unnecessary. I'm not sure if we should directly hard code the numbers with a comment next to them or have a file with a bunch of constants like this: ```javascript export const SECOND = 1000; export const MINUTE = 60 * SEC; export const HOUR = 60 * MIN; ```

👍 1