simplify age calculation #90

New issue

Closed

opened 2022-08-28 13:07:09 +00:00 by toast · 2 comments

toast commented

2022-08-28 13:07:09 +00:00

Owner

Currently we import the s-age package - which does nothing but calculate the age difference.
What's worse, it apparently does it wrong (rounding "normally" rather than down).
Replace it with a function of our own.

Currently we import the `s-age` package - which does nothing but calculate the age difference. What's worse, it apparently does it wrong (rounding "normally" rather than down). Replace it with a function of our own.

toast self-assigned this 2022-08-28 13:07:09 +00:00

toast added this to the (deleted) project 2022-08-28 13:07:10 +00:00

norm commented

2022-08-28 15:25:57 +00:00

Owner

From what I can tell, this library isn't even used so it could just be removed now.

norm commented

2022-08-28 15:31:21 +00:00

Owner

The real problem is that the time.vue component uses Math.round() in the age calculation, when it should be using Math.floor() instead.

Johann and I were discussing in IRC earlier about that, and it might mean we'll need to make a separate component for birthdays since we'd otherwise have to special case a lot just for this use case.

The real problem is that the `time.vue` component uses `Math.round()` in the age calculation, when it should be using `Math.floor()` instead. Johann and I were discussing in IRC earlier about that, and it might mean we'll need to make a separate component for birthdays since we'd otherwise have to special case a lot just for this use case.